Open-Shell / Open-Shell-Menu

Classic Shell Reborn.
MIT License
7.01k stars 433 forks source link

Change color of Classic Explorer Bar #361

Open FPN1991 opened 4 years ago

FPN1991 commented 4 years ago

I'd like to change the color of Classic Explorer Bar to match the color scheme of the Dark Mode of Windows 10. Maybe a color option on the Settings wound suffice.

Thanks

jedikalimero commented 4 years ago

Me too! The toolbar and the status bar look horrible on the Dark Mode. Also the scroll bars in the folder pane

2020-06-03

adonios77 commented 4 years ago

I have the same problem. (white background is a big problem to my eyes) I would be grateful if someone could show me where to start. I just got an idea: I haven't tried experimenting (yet) with "ResourceHacker" or "UniExtract". Is it possible to make it with one of these?

jedikalimero commented 4 years ago

I just got an idea: I haven't tried experimenting (yet) with "ResourceHacker" or "UniExtract". Is it possible to make it with one of these?

Do you mean hacking Open-Shell to change the colours? I believe is not an easy task. It is not just a harcoded colour definition but several ones: the background of the task bar, the characters in the task bar, the background of the status bar, the characters in the status bar, the scroll bars, the scroll bars background, the arrows, the arrows background, etc...

And you would be just changing to one hardcoded set of colours to another hardcoded one. I think the correct way would be for Open Shell to implement awareness of the colours the system is using and adapt dynamically to it. To ask for a palette instead of imposing a fixed one. I don't know how this is done but I'm sure there must be a system compliant way to adapt third party apps to light or dark theme (or any other theme the OS is using). When Open Shell was first programmed, there was no Dark Theme so the grey was OK but Windows interface changes and Open Shell should adapt to those changes as well as it adapts to changes in the Start Menu and other aspects that affect its functionality.

bonzibudd commented 4 years ago

I believe that the color is simply using the background "3d" color embedded in the visual style, but may just be the 3d color controllable in the classic WindowMetrics registry key.

itsdoreiku commented 4 years ago

Still waiting on this.

ThumpieBunnyEve commented 4 years ago

No interest in fixing this? no advice as to where or what to edit on our own? No direction for DIY'ers? Open office Still doesn't respect system-wide theme preference.

386 Opinion: said it most clearly i think. This issue may be older but feels less eloquently expressed then #386 https://github.com/Open-Shell/Open-Shell-Menu/issues/386

Where should we look to manually edit this ourselves until such time as it can be made a standard gui feature or plugin accessible? Both the status bar, and the OpenShell Explorer bar, disrespect the system-wide theme preference of windows 7/8/10. And clash-with/fail-to-comply-with accessibility mode settings / visual theme settings for photo sensitive and handycapped individuals.

cha0sbuster commented 3 years ago

Nothing? Still?? Dark mode came out 2 years ago, guys. I don't want to have to pick between this and not burning my eyes on Windows Explorer

blackcrack commented 3 years ago

Nothing? Still?? Dark mode came out 2 years ago, guys. I don't want to have to pick between this and not burning my eyes on Windows Explorer

@cha0sbuster : Open Source, no pay support, Community Program and bring in patches.. what have you not understand with this ?! Commooooonn, you can't not be so dump ?! You would disappoint me Brooooo ...

DCaedus commented 2 years ago

Could we have this implemented please? I love Classic Explorer toolbar, it's so useful, I just wish it had dark mode support.

Schleifenkratzer commented 1 year ago

It is the only reason I am not using it image

OrnoCav commented 1 year ago

just found this gem of an app, but I use file explorer way to much to ignore this glaring eye sore, and not encouraged that this was posted nearly 3 years ago and still no efforts to correct it

DCaedus commented 1 year ago

It seems to be working correctly for me on W11, not sure if intentional or not,

Snipaste_2023-01-21_18-17-53

OrnoCav commented 1 year ago

It seems to be working correctly for me on W11, not sure if intentional or not,

your settings are not the same/default. Just did a test on a fresh W11 and got the same result as I did on 10 with the installers default settings

Explorer Bars
Schleifenkratzer commented 1 year ago

It seems to be working correctly for me on W11, not sure if intentional or not,

Snipaste_2023-01-21_18-17-53

mind giving us access to your registry for comparison?

adonios77 commented 1 year ago

Only for Windows 7 *Note that Win7 or earlier, have totally different way to treat GraphicUserInterface to apply 'windows theme', than Win8 and later.

There are Not any default Windowz 7 DARK "aero"(transparency) themes in Control Panel>Personalization (.theme) *also, I think, unlike Pro and other editions, Win7 Starter edition (basic GUI) (Notebooks) do Not support "aero" transparency themes.) Note: It's way easier to search/read about how to installing custom windows themes. This way, you can install black/dark third party complete (downloaded) themes.

I had to make my own custom windows 7 dark theme (Windows7aero based) with a Style Builder (required). explorer-OpenShell The "Dark-Violete" windows 7 theme in the picture, my own custom theme that I use, it is not publicized yet as it's not 100% complete, as still in develop progress... when I have time.

Settings for Classic Explorer 4.4 . . . (Load/Save Backup feature in OpenShell Settings) My Explorer Settings.xml file contents XML code:

<?xml version="1.0"?>
<Settings component="Explorer" version="4.4.170">
    <NoFadeButtons value="1"/>
    <TreeItemSpacing value="-1"/>
    <FullIndent value="1"/>
    <ShowCaption value="1"/>
    <ShowIcon value="1"/>
    <DisableBreadcrumbs value="0"/>
    <AddressBarHistory value="NormalHistory"/>
    <AddressAltD value="A"/>
    <UpIconSize value="36"/>
    <UpHotkey value="8"/>
    <UseBigButtons value="0"/>
    <MenuIconSize value="24"/>
    <ToolbarListMode value="0"/>
    <SameSizeButtons value="1"/>
    <ResizeableToolbar value="1"/>
    <ToolbarItems>
        <Line>Items=UpItem,SEPARATOR,NavPaneItem,DetailsPaneItem,PreviewPaneItem,SEPARATOR,DetailsItem,SEPARATOR,FolderOptionsItem,SEPARATOR,CutItem,CopyItem,PasteItem,DeleteItem,PropertiesItem,SEPARATOR,SettingsItem</Line>
        <Line>UpItem.Command=up</Line>
        <Line>UpItem.Tip=$Toolbar.GoUp</Line>
        <Line>UpItem.Icon=,2</Line>
        <Line>UpItem.IconDisabled=,3</Line>
        <Line>NavPaneItem.Command=nav_pane</Line>
        <Line>NavPaneItem.Tip=$Toolbar.NavigationPane</Line>
        <Line>NavPaneItem.Icon=shell32.dll,16755</Line>
        <Line>DetailsPaneItem.Command=details_pane</Line>
        <Line>DetailsPaneItem.Tip=$Toolbar.DetailsPane</Line>
        <Line>DetailsPaneItem.Icon=shell32.dll,16759</Line>
        <Line>PreviewPaneItem.Command=preview_pane</Line>
        <Line>PreviewPaneItem.Tip=$Toolbar.PreviewPane</Line>
        <Line>PreviewPaneItem.Icon=shell32.dll,16757</Line>
        <Line>DetailsItem.Items=ContentItem,TilesItem,DetailsItem2,ListItem,Icons1Item,Icons2Item,Icons3Item,Icons4Item</Line>
        <Line>DetailsItem.Command=viewdetails</Line>
        <Line>DetailsItem.Tip=$Toolbar.Details</Line>
        <Line>DetailsItem.Icon=shell32.dll,62998</Line>
        <Line>ContentItem.Command=viewcontent</Line>
        <Line>ContentItem.Tip=$Toolbar.Content</Line>
        <Line>ContentItem.Icon=shell32.dll,63011</Line>
        <Line>TilesItem.Command=viewtiles</Line>
        <Line>TilesItem.Tip=$Toolbar.Tiles</Line>
        <Line>TilesItem.Icon=shell32.dll,62999</Line>
        <Line>DetailsItem2.Command=viewdetails</Line>
        <Line>DetailsItem2.Tip=$Toolbar.Details</Line>
        <Line>DetailsItem2.Icon=shell32.dll,62998</Line>
        <Line>ListItem.Command=viewlist</Line>
        <Line>ListItem.Tip=$Toolbar.List</Line>
        <Line>ListItem.Icon=shell32.dll,63000</Line>
        <Line>Icons1Item.Command=viewicons_small</Line>
        <Line>Icons1Item.Tip=$Toolbar.Small</Line>
        <Line>Icons1Item.Icon=shell32.dll,63010</Line>
        <Line>Icons2Item.Command=viewicons_medium</Line>
        <Line>Icons2Item.Tip=$Toolbar.Medium</Line>
        <Line>Icons2Item.Icon=shell32.dll,63009</Line>
        <Line>Icons3Item.Command=viewicons_large</Line>
        <Line>Icons3Item.Tip=$Toolbar.Large</Line>
        <Line>Icons3Item.Icon=shell32.dll,63008</Line>
        <Line>Icons4Item.Command=viewicons_extralarge</Line>
        <Line>Icons4Item.Tip=$Toolbar.ExtraLarge</Line>
        <Line>Icons4Item.Icon=shell32.dll,63001</Line>
        <Line>FolderOptionsItem.Items=ShowExtensionsItem,HiddenFilesItem,SystemFilesItem</Line>
        <Line>FolderOptionsItem.Command=folderoptions</Line>
        <Line>FolderOptionsItem.Tip=$Toolbar.FolderOptions</Line>
        <Line>FolderOptionsItem.Icon=imageres.dll,166</Line>
        <Line>ShowExtensionsItem.Command=show_extensions</Line>
        <Line>ShowExtensionsItem.Label=$Toolbar.ShowExtensions</Line>
        <Line>ShowExtensionsItem.Icon=none</Line>
        <Line>HiddenFilesItem.Command=hidden_files</Line>
        <Line>HiddenFilesItem.Label=$Toolbar.ShowHiddenFiles</Line>
        <Line>HiddenFilesItem.Icon=none</Line>
        <Line>SystemFilesItem.Command=system_files</Line>
        <Line>SystemFilesItem.Label=$Toolbar.ShowSystemFiles</Line>
        <Line>SystemFilesItem.Icon=none</Line>
        <Line>CutItem.Command=cut</Line>
        <Line>CutItem.Tip=$Toolbar.Cut</Line>
        <Line>CutItem.Icon=shell32.dll,16762</Line>
        <Line>CopyItem.Command=copy</Line>
        <Line>CopyItem.Tip=$Toolbar.Copy</Line>
        <Line>CopyItem.Icon=shell32.dll,243</Line>
        <Line>PasteItem.Command=paste</Line>
        <Line>PasteItem.Tip=$Toolbar.Paste</Line>
        <Line>PasteItem.Icon=shell32.dll,16763</Line>
        <Line>DeleteItem.Command=delete</Line>
        <Line>DeleteItem.Tip=$Toolbar.Delete</Line>
        <Line>DeleteItem.Icon=shell32.dll,240</Line>
        <Line>PropertiesItem.Command=properties</Line>
        <Line>PropertiesItem.Tip=$Toolbar.Properties</Line>
        <Line>PropertiesItem.Icon=shell32.dll,253</Line>
        <Line>SettingsItem.Command=settings</Line>
        <Line>SettingsItem.Tip=$Toolbar.Settings</Line>
        <Line>SettingsItem.Icon=,1</Line>
    </ToolbarItems>
    <ShareOverlay value="1"/>
    <ShareOverlayHidden value="1"/>
    <ShareExplorer value="1"/>
    <ShowHeaders value="1"/>
    <ReplaceFolderUI value="1"/>
    <OverwriteAlertLevel value="ReadOnlyFiles"/>
    <EnableMore value="1"/>
    <MoreProgressDelay value="500"/>
    <FileExplorer value="0"/>
</Settings>
ThumpieBunnyEve commented 1 year ago

adonios77 wrote: ""> I had to make my own custom windows 7 dark theme (Windows7aero based) with a Style Builder (required).""

If your going to use a required third party software to do the job and advertise the result, at least LINK to said software please. showoff. -p-

adonios77 commented 1 year ago

If your going to use a required third party software to do the job and advertise the result, at least LINK to said software please. showoff. -p-

First of all: I Do Not advertise, I'm showing my way to change bar color on Windowz7. I had to use a third-party 'cause there's no other way to fix it as There is Not default Windowz7 DARK "aero"(transparency) themes. (I think that, unlike Pro and other editions, Win7 Starter edition (basic GUI) (Notebooks) do Not support "aero" transparency themes.) Other fixes that don't satisfy me: Applying or/and modifying between "classic", "basic", "aero" default themes - graphic user interfaces. Only "classic" and "basic" styles supports changing background color but with out transparency (aero).

Off topic: Making or installing a custom theme It's bit complicated procedures (and extremely time consume) as needs to made your custom theme from scratch. I already gave a sample to have an idea for what type of program could you use. (The "Dark-Violete" theme in the picture, my own custom theme that I use, it is not publicized yet as it's still in progress.) There're guides on the internet for that... (if you going to dig so deep and you need help, or my theme as is, e-mail me) Note: It's way easier to search/read about how to installing custom windows themes. This way, you can install black/dark third party complete themes.

Schleifenkratzer commented 1 year ago

I wish you good luck with your theme, but I'm not interested in it since I'm on Win10 anyways. How about you state which vars come into question for changing it? Maybe you already know the exact one, even better. Instead of mailing with you for that top secret intel, lets do it here together and maybe you will be able to save yourself some time on the way.

Sounds win/win to me ;)

ThumpieBunnyEve commented 1 year ago

make it a community project and everyone can pitch in to help and explain and share and contribute to the good fortune collectively. ⋆^-^⋆

cody151 commented 1 year ago

Any fix for this yet?

DartVanya commented 1 year ago

May be it can be done by subclassing ToolbarWindow32 window for WM_PAINT and draw background manualy? Or it to complicated as we need draw all icons and separators manually too? Sory for dumb qustions, I'm not very good at this.

Yes, it kinda impossible. I tried custom toolbar draw for testing. It still works, but we need to draw all icons and separators, and also handle mouse hover and press events to properly draw buttons. And another problem what this white line on toolbar left part is another ToolbarWindow32 belongs to window's menu. This menu can randomly appears (it happens on WM_SETTINGCHANGE). And to change color of menu need do same thing...

It's sad, what Microsoft doesn't add support for dark theme in toolbars.

screenshot1

jswinde commented 11 months ago

Is there a way to at least turn off the toolbar permanently? Unchecking the "classic toolbar" from the right click menu only disables it until you relaunch File Explorer. I am ONLY using Classic Explorer to show the free disk space in the status bar (Windows 11).

KamiyaMinoru commented 8 months ago

same issue in Win 10 anyway body can help? Thanks. image

adonios77 commented 8 months ago

I believe that the color is simply using the background "3d" color embedded in the visual style, but may just be the 3d color controllable in the classic WindowMetrics registry key.

No, it's not there. Same with any Windows from 7 to 11.

adonios77 commented 8 months ago

Forget it mates. Theres no way because the most people think that the bright white background is not a problem at all. Between those people are also the "classic explorer bar" developers. They think it's matter of taste, they don't believe it's blinding for a lot of pairs of eyes. So: Forget it. Edit: I'm so glad that I was wrong and finally someone got involved and fixed this problem! A thousand Bravo and thanks again.

DartVanya commented 8 months ago

Forget it mates. Theres no way because the most people think that the bright white background is not a problem at all. Between those people are also the "classic explorer bar" developers. They think it's matter of taste, they don't believe it's blinding for a lot of pairs of eyes. So: FORGET IT.

You can try my fork. I added full support for Dark Mode, both for Toolbar and Statusbar. Theme will be same as system and will automatic change when system theme is changing. Also I add ability to lock Toolbar to fixed position. This will suppress menu bar (it can be randomly appears on WM_SETTINGCHANGE) and lock toolbar to selected position.

https://github.com/Open-Shell/Open-Shell-Menu/assets/13500760/c134bc0d-b05d-4bfc-9a11-66dc7453cd96

I am using it for several month, all works pretty stable. Hope you can test and tell me how it works on your system. Compiled installer can be funded in releases section.

ge0rdi commented 8 months ago

@DartVanya

I added full support for Dark Mode, both for Toolbar and Statusbar.

You can submit PR with those changes, so that others can benefit from them too.

Also I add ability to lock Toolbar to fixed position. This will supress menu bar (it can be randomly appears on WM_SETTINGCHANGE) and lock toolbar to selected position.

Interesting. Do you have any idea what could cause that menu bar to appear? I guess there were few reports of that but I was unable to replicate it. Anyways, feel free to submit these improvements as well.

jedikalimero commented 8 months ago

You can try my fork. I added full support for Dark Mode, both for Toolbar and Statusbar. Theme will be same as system and will automatic change when system theme is changinge. Also I add ability to lock Toolbar to fixed position. This will supress menu bar (it can be randomly appears on WM_SETTINGCHANGE) and lock toolbar to selected position.

That seems exactly what we have been waiting for 4 years! Toolbar, status bar and folder pane scrollbar, all fixed in a single fork. And you fixed the randomly appearing menu bar too? Amazing

Can't wait to try it. Thank you very much, @DartVanya

DartVanya commented 8 months ago

Do you have any idea what could cause that menu bar to appear?

SendMessage(HWND_BROADCAST, WM_SETTINGCHANGE, 0, 0); Always throws menu bar. This also can happens when system settings is changing and this message is being broadcasted.

KamiyaMinoru commented 8 months ago

Forget it mates. Theres no way because the most people think that the bright white background is not a problem at all. Between those people are also the "classic explorer bar" developers. They think it's matter of taste, they don't believe it's blinding for a lot of pairs of eyes. So: FORGET IT.

You can try my fork. I added full support for Dark Mode, both for Toolbar and Statusbar. Theme will be same as system and will automatic change when system theme is changinge. Also I add ability to lock Toolbar to fixed position. This will supress menu bar (it can be randomly appears on WM_SETTINGCHANGE) and lock toolbar to selected position.

Open.Shell.DM.mp4 I am using it for several month, all works pretty stable. Hope you can test and tell me how it works on your system. Compiled installer can be funded in releases section.

Hi, it looks so pretty, but a quick question: do I just install it to overwrite the existing open-shell, and my current setting (and tools bars, icons...) will keep the same? Thanks.

DartVanya commented 8 months ago

Yes, it should update with keep settings, because dev version 1000 is higher than currently official release version. If no, you can export settings and do uninstall-install-import settings.

KamiyaMinoru commented 7 months ago

Forget it mates. Theres no way because the most people think that the bright white background is not a problem at all. Between those people are also the "classic explorer bar" developers. They think it's matter of taste, they don't believe it's blinding for a lot of pairs of eyes. So: FORGET IT.

You can try my fork. I added full support for Dark Mode, both for Toolbar and Statusbar. Theme will be same as system and will automatic change when system theme is changing. Also I add ability to lock Toolbar to fixed position. This will suppress menu bar (it can be randomly appears on WM_SETTINGCHANGE) and lock toolbar to selected position.

Open.Shell.DM.mp4 I am using it for several month, all works pretty stable. Hope you can test and tell me how it works on your system. Compiled installer can be funded in releases section.

Hi DartVanya (and who tend to try it)

Some screenshots (and found, with my first minute using) for your reference: green arrows: Yes, fixed red arrows: no

image image image image

When I access/jump to another folder, the background color of explore will become white for half second, hurts my eyes. Thank you and glad to see a better dark mode for fork it anyway

with my Windows 10

Artdigy commented 5 months ago

Hey Adonios, I am sorry to necro on a opened issue, but I stumbled across this thread and saw your Windows 7 theme. I think it's absolutely stunning. I was wondering if you ever continued work on it or would consider sharing it? If it's for personal use, I understand. It's amazing.

goobdevTM commented 3 months ago

Forget it mates. Theres no way because the most people think that the bright white background is not a problem at all. Between those people are also the "classic explorer bar" developers. They think it's matter of taste, they don't believe it's blinding for a lot of pairs of eyes. So: FORGET IT.

You can try my fork. I added full support for Dark Mode, both for Toolbar and Statusbar. Theme will be same as system and will automatic change when system theme is changing. Also I add ability to lock Toolbar to fixed position. This will suppress menu bar (it can be randomly appears on WM_SETTINGCHANGE) and lock toolbar to selected position.

Open.Shell.DM.mp4 I am using it for several month, all works pretty stable. Hope you can test and tell me how it works on your system. Compiled installer can be funded in releases section.

Thank you SO MUCH for this! I tried this and it worked perfectly! I was a little worried it wouldn't keep my windows 7 theme, but it did! Now I won't be going blind anytime soon Screenshot 2024-08-03 104412

adonios77 commented 3 months ago

Hey Adonios, I am sorry to necro on a opened issue, but I stumbled across this thread and saw your Windows 7 theme. I think it's absolutely stunning. I was wondering if you ever continued work on it or would consider sharing it? If it's for personal use, I understand. It's amazing.

Thank you and Sorry for the (very) late reply. I'm still using this theme ("Dark Violette", I've made for my own use) without improving it at all since then (it has a few 'glitches'). Nevertheless: I'm not an 'advanced' user, and this wasn't a 'job' or 'work' in the commercial sense but just spending my time trying. Having no other choice, I found scattered 'unofficial and unconfirmed' information and 'hacks', mostly on various 'blocked' pages (under the guise of security, rights, etc.), but which promote sharing, and I have used 'third party' programs which I have no right to share. I'm sorry but I'm not the one who enforces the existing laws and rules. Sorry for my English too.

NotNekodev commented 3 months ago

Forget it mates. Theres no way because the most people think that the bright white background is not a problem at all. Between those people are also the "classic explorer bar" developers. They think it's matter of taste, they don't believe it's blinding for a lot of pairs of eyes. So: FORGET IT.

You can try my fork. I added full support for Dark Mode, both for Toolbar and Statusbar. Theme will be same as system and will automatic change when system theme is changing. Also I add ability to lock Toolbar to fixed position. This will suppress menu bar (it can be randomly appears on WM_SETTINGCHANGE) and lock toolbar to selected position. Open.Shell.DM.mp4 I am using it for several month, all works pretty stable. Hope you can test and tell me how it works on your system. Compiled installer can be funded in releases section.

Thank you SO MUCH for this! I tried this and it worked perfectly! I was a little worried it wouldn't keep my windows 7 theme, but it did! Now I won't be going blind anytime soon Screenshot 2024-08-03 104412

Is it only in Windows 11 I dont really want ot switch to Windows 11 just for a stupid bar

DartVanya commented 3 months ago

Is it only in Windows 11 I dont really want ot switch to Windows 11 just for a stupid bar

I haven't tested it on Windows 10 before, because all my PCs on Win11. I tested on 22H2, all works. I committed some minor fixes for rebar drawing.

https://github.com/user-attachments/assets/8519cbde-30e1-489d-9d33-b259f0219302

Note. If you using toolbar with right position bottom separator line can be broken by phantom menu bar. To fix that use Toolbar Settings - Lock toolbar - select the desired position. I recompilled the setup, see last release.

Spartahog commented 2 months ago

Is it only in Windows 11 I dont really want ot switch to Windows 11 just for a stupid bar

I haven't tested it on Windows 10 before, because all my PCs on Win11. I tested on 22H2, all works. I committed some minor fixes for rebar drawing. explorer_xkXEyM9OsX.mp4

Note. If you using toolbar with right position bottom separator line can be broken by phantom menu bar. To fix that use Toolbar Settings - Lock toolbar - select the desired position. I recompilled the setup, see last release.

Tested it on Windows 10. Did not have to touch my settings, it works wonderfully. Many thanks. GjXpLKYSDO