Open-Shell / Open-Shell-Menu

Classic Shell Reborn.
MIT License
6.94k stars 431 forks source link

Don't update search result while trying to click it #4

Open Brummolix opened 6 years ago

Brummolix commented 6 years ago

May I suggest one improvement.

When I start a search the result (for example a document) may be shown already. Often it happens that I want to click the result but at the same time the search result is updated again (with even more results) and then I click a different result (document). This is annoying. I suggest to not update the search result when there is already a result and the mouse is over the search result.

mailinglists35 commented 6 years ago

This is annoying.

+1

B00ze64 commented 6 years ago

Lol, I haven't had a problem with that so far, but the Windows Control Panel does this to me EVERY time I use it, and it is so annoying! You suggestion is quite interesting, but might be a bit complex to code properly...

coddec commented 6 years ago

One workaround is get a SSD or M.2 The search results will appear faster (Less chance to update the list while clicking, but not 100% immune)

nyanpasu64 commented 6 years ago

I'm already using a SSD, so the above suggestion is neither a proper fix, nor a fix at all.

I'm using Windows 7 layout, and keyboard arrow keys to move through icons. While the currently selected menu item is maintained, the ones below your cursor may disappear without warning. If I type "net" and select Program 4, when the Programs section collapses to 3 items, the cursor jumps to Program 1!

If I'm trying to press Down 3 times to reach Program 4, Program 4 may disappear while I'm scrolling through the list.

coddec commented 6 years ago

Probably a similar approach like Windows 10 native start menu will do? (the Best match part in Windows 10 star menu)

Ibuprophen commented 5 years ago

@Brummolix, to me, this issue looks like it's being addressed (in a similar/same fashion) within the https://github.com/Open-Shell/Open-Shell-Menu/issues/57 issue.

I just don't want to jump the gun on this assumption but, this topic of discussion seems to have been stopped for a very long time and, since you're the OP Issuer, should this be closed to point to the issue I had just referenced?

Thank you very much for your time and understanding with this question.

~Ibuprophen

Brummolix commented 5 years ago

I'm not sure where you see the connection between these 2?

57 is talking about not finding certain settings. But this one is about the presentation of the search results (and the fact that you might press the wrong item when the search results are updated)

Ibuprophen commented 5 years ago

I may have been wrong with the connection... My apologies.

Is this happening with the latest version of the Open Shell?

I tried to duplicate this but, I can't.

Maybe you can elaborate more on this a bit regarding the OS and exactly what you're doing that results in this behavior.

~Ibuprophen

Brummolix commented 5 years ago

I installed 4.4.131 The search seem to be a bit faster so you do not realize the problem so often, but it is still there. You can see it if you search for something that still take some time to search, for example search for "x"

Ibuprophen commented 5 years ago

@Brummolix, just as a suggestion, give the following build a try...

https://ci.appveyor.com/api/buildjobs/14f8l0ai2a9patoa/artifacts/OpenShellSetup_4_4_138.exe

It has a handful of fixes applied that hasn't officially been released yet (as more work is still being performed/applied).

I'm keeping my fingers crossed! 🖖

~Ibuprophen

ge0rdi commented 5 years ago

I'm afraid there was no fix done that could even remotely relate to the issue reported here.

Ibuprophen commented 5 years ago

I just took a gamble... LOL!

q00u commented 4 years ago

Any updates on this? The Search box is the only thing I can't stand about "Classic with two columns". Search results get added and everything MOVES UP, and it can happen at any time (such as right before you click ). It's not as bad with "Windows 7 style", as I usually want something from the top results and there things mostly get added below that, so it's (usually) safe to click.

This is a problem in Open-Shell 4.4.142, but it's always been a problem.

blackcrack commented 4 years ago

*imho close and end the Support-hotline for this Issue *bg to long pipe *imho* ! :grin:

bonzibudd commented 4 years ago

I think this would be improved drastically if #463 was implemented. Less results to clutter up the search process.

tim-elmer commented 1 year ago

I noticed this issue myself recently, and it seems - at least in my case - to be caused by results from the filesystem being populated, shrinking the lists of "system" results. A potential fix that comes to mind would be to reserve a set number of filesystem result spaces in the layout for the slower filesystem search when initially populating the result UI, so that the "system" result lists don't need to shrink reactively.

Alternatively, display the search results in a scroll pane, with the number of items shown in a collapsed group still respected, so that the list can expand without moving under the cursor.