search

Open-Shell / Open-Shell-Menu

Classic Shell Reborn.
MIT License
7.01k stars 433 forks source link

Start menu Search box text becomes increasingly off-center at higher DPI/font size #465

Open bonzibudd opened 4 years ago

bonzibudd commented 4 years ago

Describe the bug The search box which Open-Shell menu uses displays text, which should be centered vertically. The text becomes too high at increased DPI settings, including 144, 168, 192, etc.

To Reproduce Steps to reproduce the behavior:

  1. Open the Start Menu with a classic style menu enabled, at a high DPI setting
  2. Notice the text is too high within the Search box. This is a problem in all types of skins, but more clearly demonstrated in Classic styles, since they do not use a Search background which may affect the placement.

Expected behavior The text should be centered vertically.

Screenshots Search box at 192 dpi Search box at 192 dpi

Version:

Additional context Not necessarily a usability issue, although I suppose it could be at extraordinary resolutions. Even here, you can see that the text is at the very edge of overlapping, or could already be. I suspect that there is an alignment setting which does not scale well. To add to this, I will clarify that this occurs with both italic and normal font settings.

bonzibudd commented 4 years ago

Forgot to mention that this is NOT related to the new DPI update. This has been an issue for a while.

bonzibudd commented 3 years ago

It seems like it might be possible to modify that padding within the skin, but I've had no luck so far. If I find a solution I'll close the issue.