search

Open-Shell / Open-Shell-Menu

Classic Shell Reborn.
MIT License
6.88k stars 427 forks source link

Start Button Off By 1 Pixel & Incorrect "Pressed" Image in Windows 8.1 #521

Open SL6464 opened 3 years ago

SL6464 commented 3 years ago

Hi. I've been using Classic/Open-Shell for many years now and absolutely love the software, however one issue I've always had with it on Windows 8.1 is how the start button is handled.

Screenshots

https://i.imgur.com/ZcFbSW6.png

https://i.imgur.com/J7ISgDW.png

The first image is WITH Open-Shell; the second is without, and both images show (from top to bottom): normal, hover, pressed. You'll note that the WITH Open-Shell image has 1px less spacing on the left hand side, and also the pressed version doesn't turn grey and is actually just the same as the normal one. I asked about this on the Classic Shell forum some years ago and was told the 1px move was done to prevent the Start Screen from opening instead. Is there any way this could be fixed in a future update so that the start button on 8.1 looks 100% identical to how it looks without Open-Shell? I appreciate that 8.1 probably isn't any kind of priority but I still use it. Thanks.

To Reproduce Steps to reproduce the behavior:

  1. Click start button on 8.1 with Open-Shell disabled;
  2. Click start button on 8.1 with Open-Shell enabled;
  3. Compare results.

Expected behavior Start button should have the same left-hand padding and "pressed" image that it has without running Open-Shell.

Screenshots See above.

Version:

Thanks.

bonzibudd commented 3 years ago

To add to this: The "pressed" state has the same issue in Win10. Not sure about 7, but it may work better since the default button is less complex.

SL6464 commented 3 years ago

Hi, can someone please confirm if this is something that can be fixed in a future update?

I have noticed that if the taskbar is at the top of the screen, the issue isn't present and the Windows flag has 12px of space on either side, but when it's in its normal place at the bottom of the screen, the left side only has 11px of space.

If it's not likely to be fixed, can someone at least tell me where to go in the repository to edit the 1 pixel thing myself so that I can compile a version of the software for my own personal use?

Thanks again.