search

Open-Smartwatch / open-smartwatch-os

The Open-Smartwatch Operating System.
https://open-smartwatch.github.io
GNU General Public License v3.0
998 stars 163 forks source link

Fix warnings #297

Closed jessp01 closed 2 years ago

jessp01 commented 2 years ago

Fix ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second warnings.

uvwxy commented 2 years ago

Thank you @jessp01 !

If you squash the commits into one (as the last two are merely cleanup of the first), this should be ready to be merged.

(I'm not familiar enough with c++ at this point to understand the warning, but maybe this led to this in the first place ;) )

If you need any input to do this, please let us know. 👍

simonmicro commented 2 years ago

@jessp01 Hey, thanks for patching this. I've not done that myself, as I wanted to squash the problem at its root and note by merely work-arounding the symptoms. I'll take a look into this by myself again, but maybe we'll just go with this instead.

simonmicro commented 2 years ago

And yes, as @uvwxy already mentioned - whoever merges this: Please squash the commits!

Maybe this is a note to my future-self, which will 100% ignore this...

simonmicro commented 2 years ago

And therefore that commit is the proper fix. Thanks for your attempt to fix this, it was just at the wrong place. :grin: