search

Open-Smartwatch / open-smartwatch-os

The Open-Smartwatch Operating System.
https://open-smartwatch.github.io
GNU General Public License v3.0
967 stars 155 forks source link

Bug/gif bg flag #363

Closed simonmicro closed 1 year ago

simonmicro commented 1 year ago

Fixes #362

I also needed to redesign the workflows to work with multiple flags defined at the same time, as the build-script was not proper cleaning all defines before (which caused size-problems with the GIF_BG flag). After changing that, too many flags were removed, so I re-engineered the flag-extraction from the docs to just contain all required ones.

simonmicro commented 1 year ago

Here you go @RuffaloLavoisier :wink:

simonmicro commented 1 year ago

@RuffaloLavoisier I have to admit, that I'm no real fan of concatenating if ...: continue statements into one-liners. Their existence have a severe impact onto the code execution flow and should not (especially if they are not the first statement) be hidden under the rest of the logic. On the other hand, I do not think that they are that important to justify multiple empty new lines before and after or own comments to highlight them again if they are concatenated.