Open-Sn / opensn

open-source Sn software
https://open-sn.github.io/opensn/
Other
21 stars 17 forks source link

what happened to this file SimTest_IP_MMS_L2error ? #311

Open ragusa opened 4 months ago

ragusa commented 4 months ago

in test/modules/dfem_diffusion/d_diffusion_2d_3c_l2_error_mms.lua, we had a method SimTest_IP_MMS_L2error() that was useful to do manufactured solutions and check convergence rates. I wrote it and use it to found a bug on the IP implementation. If I remember correctly, this was an example of using the software as a library and write one's little code with the library. We didn't want to have manufactured solution (MS) as part of the code itself, but we were happy to test MS on the side. I would appreciate if we could resurrect this. I could even use it as a tutorial on how to write a new code, using opensn as a library.

andrsd commented 3 months ago

The d_diffusion_2d_3c_l2_error_mms.lua file has not been included in testing since the beginning of the OpenSn repo. There were change made on the file, but since it was not being executed, we don't know if it works.

As for SimTest_IP_MMS_L2error function. Current main has only 1 reference and it is from the d_diffusion_2d_3c_l2_error_mms.lua file. The early version of OpenSn (6e871bdd) has 2 references: (1) dDiffusion_2D_3c_L2_error_MMS.lua and (2) doc/scripts/mainpage_quickref.txt. So, was the file that implemented the function even transferred from ChiTech?

ragusa commented 3 months ago

can you look here? https://github.com/chi-tech/chi-tech/tree/1b5ac1057b0836db7ca87d88678131e2dd10b3de/framework/LuaTest It would be good to revive this because (1) it could be an exmaple on how to use opensn as a library and (2) it has a manufactured solution and this helped me find a bug long time ago