search

Open-Source-Compliance / Sharing-creates-value

This repo realizes the idea that OSS compliance activities will be less expensive by applying OSS principles
Creative Commons Zero v1.0 Universal
83 stars 36 forks source link

Fixes of typos and minor rewording in User-Storie Epics #84

Closed mgruhler closed 4 years ago

mgruhler commented 4 years ago

Hi all,

I've stumbled upon a few typos in the provided Epics and thought I'll just submit an update.

I've tried to keep the changes as small as possible, but didn't manage to keep my fingers from a few minor rewordings/simplifications :grin:. But they should all be fairly easy to check.

Few points to note:

  1. I unified usage of "third party" and "3rd party", choosing the latter as it is used more often
  2. in Legal-Assessor-Epic.md one of the last sentences read: "I need to have the ability to immediately inform the product owner when a certain license or organization cannot be accepted", I assume this should be "component" or similar. I made this change, but please provide feedback if this is correct.
  3. I changed all occurrences of "in respect to" to "with respect to". I'm no native speaker, so there might be a legal distinction there, but afair, there is "in respect of" and "with respect to", but no "in respect to". Please do let me know if this change is not correct and I'll revert that.

Last, a suggestion: As you can see in the diff below, git (and especially github) starts to struggle highlighting word-based diffs on long lines. For easier review of PRs, it would be good to add a line break after each sentence in the .md files. This will still render the same, but help with reviewing small changes in long paragraphs.

So much for that. Thank you for your excellent work! Keep it up!

OliverFendt commented 4 years ago

@mgruhler thank you for your review and corrections