search

Open-Source-Digital-Twin / furuta-pendulum-controller

MIT License
2 stars 1 forks source link

Removing <json> from the Controller's contructor #31

Closed LLagu closed 10 months ago

LLagu commented 10 months ago

Templating one of the the Controller constructor's parameters meant moving its definition in the header (my understanding is that compiler only sees the header so if the method is templated it could cause a "panic", but I'd like to know more) and adding .template because of this.

Let me know what you think and if there is a more elegant solution. :)

caiopiccirillo commented 10 months ago

Change the commit message of https://github.com/Open-Source-Digital-Twin/inverted-pendulum-controller/pull/31/commits/41e9dbf8a50b82493fd6f4fda525438a653ff939. Commit messages are "permanent", so we should try to keep as descriptive as possible 😄