Open rflmota opened 3 years ago
are you sure that the Telemetry tab
is right? did you remove the changes i did? Im looking at spec KS-DOC-01104: 5.3 Telemetry PLAT_COMMS_00105
Hi @dennisolien ,
I just checked the document KS-DOC-01104 OSSAT Mercury GS Specification_03
and I guess you're right, maybe I was referring to a older version of specs, but I didn't noticed that a new subsection Last Failure
was added to the form.
Also I didn't include the TLM CH1..3
as in the example provided, because my reasoning is that information is dynamic and several channels may be added more than 1..3
(maybe we should place a scrollable text area for this?
I can have a look and try to fix this later or you can go ahead and replace with your own, tell me what you think
@dennisolien , regarding your changes, I didn't removed, but I also didn't merged with mine, I had previously designed the form and when I noticed your #4, I just decided to push my version upstream since already included tabs LOG
and TEST
from your todo list. But in case it just gives you more trouble merging the branch, just drop my changes.
@rflmota this is really helpful, im just reimplementing it in my main branch. In your version there is some problems with the names of ui elements, so i'm just going over one tab at the time, copying in your work with the right name on the elements.
and i agree on the TLM CH1..3
stuff.
I think all of this is added in #4, can you @rflmota check if master and this branch have feature parity.
Hi @dennisolien
I've retouched Qt UI layout to be concordant to MercuryGS requirements document. I guess I haven't broken any functionality regarding your previous commits, but I ask you to test and review.
Telecommanding tab
Telemetry tab
File Transfer tab
Config tab
Test tab