search

Open-Source-Spatial-Clean-Cooking-Tool / OnStove

This repository contain the general code for the Open Source Spatial Clean Cooking Tool OnStove
MIT License
7 stars 8 forks source link

Raise error when values in specs are missing #281

Closed babakkhavari closed 1 year ago

babakkhavari commented 1 year ago

Not all parameters are given default values in the specs file (see #280). Raise an error when values are missing

camiloramirezgo commented 1 year ago

This feature introduced an error when the user wants to run the model in separate model preparation and running steps, as not all parameters are in the prep file, raising an error. I think it would be good to keep the possibility of running in different steps as that gives more flexibility for scenario development. If we go with that, then we need to find a way of avoiding the issue. One option would be to call the method later in the process, as before running the model to make sure all parameters needed are.