Open-Source-Spatial-Clean-Cooking-Tool / OnStove

This repository contain the general code for the Open Source Spatial Clean Cooking Tool OnStove
MIT License
7 stars 9 forks source link

Update current shares used in `discounted_inv` based on the new calibration methods #307

Closed camiloramirezgo closed 8 months ago

camiloramirezgo commented 1 year ago

Currently, the shares used in the discounted_inv methods to calculate the relative costs against the baseline (of the LPG and Electricity classes) are still based on the single numbers for rural and urban settlements, this needs to be changed to use the output of the new calibration methods.

This are the parts that need update: https://github.com/Open-Source-Spatial-Clean-Cooking-Tool/OnStove/blob/7c1fea1c4fd1ff97c3c9b99987696a7ca5732e47/onstove/technology.py#L1001-L1003 and https://github.com/Open-Source-Spatial-Clean-Cooking-Tool/OnStove/blob/7c1fea1c4fd1ff97c3c9b99987696a7ca5732e47/onstove/technology.py#L1648-L1650

We still need to check if we need to save any additional information from the calibration process to be used in the methods.