Open-Source-Spatial-Clean-Cooking-Tool / OnStove

This repository contain the general code for the Open Source Spatial Clean Cooking Tool OnStove
MIT License
7 stars 8 forks source link

Improve step one of the notebook #339

Closed camiloramirezgo closed 1 year ago

babakkhavari commented 1 year ago

Fixed

Test it for bugs and make sure that the explaining text is correct

camiloramirezgo commented 1 year ago

When we make the release, we will need to remove the sys.path.append("..") line and the autoreloads. We will also need to update the paths as output_directory = '../example/results' I spect the behaviour to be that the user will be able to just download the example notebook, install onstove with conda and run the notebook directly being in the same directory. So the ../example won't be really required.

camiloramirezgo commented 1 year ago

I want to "hide" the data download steps into a function that gets called with the country as input only. We can put this function on a utils.py file in the example and import it. I think this will make the notebook cleaner and will avoid confusion among the participants about those download steps.

camiloramirezgo commented 1 year ago

Thing done: