Open-Systems-Pharmacology / Forum

Discussion forum for the Open Systems Pharmacology Project
65 stars 19 forks source link

MoBi new organ #98

Closed watt0005 closed 6 years ago

watt0005 commented 6 years ago

In the previous version of MoBi, if I wanted to add an organ to the model, I would go through the following process:

  1. Click on a similar existing organ and save as .pkml (essentially using it as a template for the new organ)
  2. In the tree view, go to Load Container, select the saved .pkml and rename it
  3. Set up neighborhoods, tags, kinetics of mass transfer, etc

Now when I Load Container (e.g., Lung.pkml) and rename it, it not only renames the new organ but also the original (eg Lung) organ.

Is there a way to do this in MoBi 7.1?

msevestre commented 6 years ago

Hi @watt0005

I cannot reproduce the problem you are describing

Where are you clicking in the step 2 In the tree view, go to Load Container, select the saved .pkml and rename it ?

I have tried with the bone organ (as well as the lung organ) and I have now the old bone container and the new one (see screenshot) image

Can you help me reproduce the bug. Maybe there is a step that you are performing that is not mentioned in your description?

Thanks

watt0005 commented 6 years ago

Hi Michael- you are correct – I was not doing exactly what I wrote. When I go to the tree view and right click on Organism and load container, it asks first if I want to rename the container. Once I do that the new organ is added and I can proceed by adding neighborhoods, tags, etc. So problem solved.

Where I had the problem was when I tried to load the container in the Diagram view. When I clicked on Load Container in the upper left corner and loaded a saved .pkml file, it did not ask if I wanted to rename. When I manually right click the new organ and select Rename, I am presented with the following:

[cid:image001.png@01D36389.04F06890]

If I click OK, then both the organs are renamed LungNew

[cid:image002.png@01D36389.04F06890]

So nothing additional needed for me as I can use the first method. But I am curious why the different options depending on the Tree or Diagram view and if it is possible to make this work from the Tree view.

Thanks, Kevin

Kevin Watt, MD PhD Assistant Professor of Pediatrics Duke University Medical Center Duke Clinical Research Institute Phone: 919-668-8556 kevin.watt@duke.edumailto:kevin.watt@duke.edu

From: Michael Sevestre [mailto:notifications@github.com] Sent: Wednesday, November 22, 2017 11:41 AM To: Open-Systems-Pharmacology/Forum Forum@noreply.github.com Cc: Kevin Watt kevin.watt@duke.edu; Mention mention@noreply.github.com Subject: Re: [Open-Systems-Pharmacology/Forum] MoBi new organ (#98)

Hi @watt0005https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_watt0005&d=DwMFaQ&c=imBPVzF25OnBgGmVOlcsiEgHoG1i6YHLR0Sj_gZ4adc&r=6y5N0H1uA8ek2x7-VitI2EJptPfKG-xkY8SbtTY0uqo&m=oO1ce8gU8MZT-yoHxXSQuaYXsjC0ona-_LOZSLC-OiU&s=4hH40aHD9HMcHPKjSGa4Q9EPjillo6tlLzjU3WX_igY&e=

I cannot reproduce the problem you are describing

Where are you clicking in the step 2 In the tree view, go to Load Container, select the saved .pkml and rename it ?

I have tried with the bone organ (as well as the lung organ) and I have now the old bone container and the new one (see screenshot) [image]https://urldefense.proofpoint.com/v2/url?u=https-3A__user-2Dimages.githubusercontent.com_1041237_33138959-2Dd7baddf8-2Dcf79-2D11e7-2D9534-2D9b21811d702b.png&d=DwMFaQ&c=imBPVzF25OnBgGmVOlcsiEgHoG1i6YHLR0Sj_gZ4adc&r=6y5N0H1uA8ek2x7-VitI2EJptPfKG-xkY8SbtTY0uqo&m=oO1ce8gU8MZT-yoHxXSQuaYXsjC0ona-_LOZSLC-OiU&s=ZcwmYRRHbqZ6IPTuGFII0widR35imBmf4MmqSUM1g04&e=

Can you help me reproduce the bug. Maybe there is a step that you are performing that is not mentioned in your description?

Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Open-2DSystems-2DPharmacology_Forum_issues_98-23issuecomment-2D346406451&d=DwMFaQ&c=imBPVzF25OnBgGmVOlcsiEgHoG1i6YHLR0Sj_gZ4adc&r=6y5N0H1uA8ek2x7-VitI2EJptPfKG-xkY8SbtTY0uqo&m=oO1ce8gU8MZT-yoHxXSQuaYXsjC0ona-_LOZSLC-OiU&s=d7iwKsb6dFbNDhB8DWj1dTCnGPM6PewmMF0NpbOA3Ao&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_Ad3sfdQCSIUhCajiotKsJTLXnToZVI5cks5s5E6MgaJpZM4QnXpY&d=DwMFaQ&c=imBPVzF25OnBgGmVOlcsiEgHoG1i6YHLR0Sj_gZ4adc&r=6y5N0H1uA8ek2x7-VitI2EJptPfKG-xkY8SbtTY0uqo&m=oO1ce8gU8MZT-yoHxXSQuaYXsjC0ona-_LOZSLC-OiU&s=gWqRzAhD4irurVc5208dZ-ByVVSUx640XUUKjEtmf4Y&e=.

msevestre commented 6 years ago

@watt0005 Unfortunately your images are removed when answering via email :( But I think I get the gist of the problem. Diagram and TreeView SHOULD BEHAVE THE SAME as this is just a different view of the same data. Clearly the Diagram implementation is not correct and this should be changed. I am going to close this issue and create a bug report in the MoBi project

Thanks for the clarification :)

msevestre commented 6 years ago

@watt0005 I cannot reproduce the issue in the diagram either... Could you add those screenshots via Github after all :)

watt0005 commented 6 years ago

neworgan1 neworgan2

msevestre commented 6 years ago

@watt0005 Interesting I am wondering how you managed to add another organ with the name Lung. I tried the same workflow and MoBi asks me to rename the Lung organ

image

and then after rename image

So there is a bug... but hard to reproduce :(

Christoph27 commented 6 years ago

By the way: Be aware that lung is a special organ (e.g. blood flow is an equation summing up the blood flow of all other organs) . Depending on what you want to do, you might consider using a "normal" organ e.g. gonads or heart as template.
I had not the Problems described with naming (as Michael described, MoBi asks me to re-name and after that only the new organ has the new name ...)

watt0005 commented 6 years ago

Interesting. I just reproduced. Exact steps were:

  1. Export simulation from PK Sim to MoBi
  2. Open the Spatial Structure
  3. Click Load under the Add group in the top left corner
  4. Select Lung.pkml
  5. I am then prompted to rename the different neighborhoods (eg Lung_pls_Lung_int) but not asked to rename the organ
Christoph27 commented 6 years ago

I don't understand the 3. step: "under the Add group in the top left corner"

The steps which work in my example:

  1. Simulation exported to MoBi
  2. In the spatial structure: save an organ as pkml (e.g. heart)
  3. In the spatial structure: at Organism level (tree or diagram view) -> right click -> load container -> select pkml file
  4. A window pops up asking to "select containers to load" -> select top container i.e. in this case "heart"
  5. A window pops up asking you to rename the container. -> Rename
  6. After that, rename the neighbourhoods accordingly in the windows pooping up successively.
watt0005 commented 6 years ago

When on the Diagram screen, I am not right-clicking to load container. I am clicking the Load button in the screen shot below: image

msevestre commented 6 years ago

Ah ah. Thanks @watt0005 . This was the missing piece

msevestre commented 6 years ago

I created an issue for MoBi. Thanks @watt0005