search

Open-Systems-Pharmacology / MoBi

MoBi® is a software tool for multiscale physiological modeling and simulation
Other
29 stars 9 forks source link

Display of Table Formula and TableFormulaWithXArguments #1040

Closed msevestre closed 3 weeks ago

msevestre commented 1 year ago

@PavelBal @rwmcintosh @Yuri05 We have them now in Expression Profile and in the simulation

see attached project Ontogeny_factor.zip

Thsi is in the simulation image

This is in the expression profile image

In short. We have no idea what's going on. The values are correct but it's a bit..useless

msevestre commented 1 year ago

image

PavelBal commented 1 year ago

The best way would probably be - by clicking on the cell, a view of the table opens. This is probably not easy to implement without sacrificing the drop-down for formula selection.

Alternative - only show the name of the formula, and the user must go to the "Formulas" tab to view it.

Yuri05 commented 1 year ago

Table with argument parameters (Ontogeny factor and Ontogeny factor GI obviously cannot be displayed and showing <Not Available> is OK. For the table parameters: would prefer the same way as in PK-Sim (e.g. for pH-Solubility table in compound):

PavelBal commented 11 months ago

This comment separated into issue https://github.com/Open-Systems-Pharmacology/MoBi/issues/1396

Update: The formula with argument is located in the molecule, the expression profiel only holds the table formula. However, these are not displayed (selecting a table formula in the "Formulas" tab crashes:

Application: MoBi® 12.0.75

Formula 'DistributedTableFormula' not supported at the moment

Stack trace:

at MoBi.Presentation.Presenter.FormulaPresenterCache.PresenterFor(Type formulaType)
   at MoBi.Presentation.Presenter.FormulaPresenterCache.PresenterFor(IFormula formula)
   at MoBi.Presentation.Presenter.FormulaCachePresenter.Select(IFormula formula)
   at MoBi.Presentation.Presenter.FormulaCachePresenter.Select(FormulaBuilderDTO formulaDTO)
   at MoBi.UI.Views.FormulaCacheView.<>c__DisplayClass4_1.<InitializeBinding>b__7()
   at OSPSuite.UI.Controls.BaseUserControl.<>c__DisplayClass23_0.<OnEvent>b__0()
   at OSPSuite.Utility.Extensions.ExceptionExtensions.DoWithinExceptionHandler(Object callerObject, Action actionToExecute)

image

proposed solution: in the parameters list, show the name of the formula, which can be viewed in the "Formulas"-tab.

rwmcintosh commented 3 weeks ago

This is going to be closed as nothing left to do after #1396 and #1395 are done.