Open-Systems-Pharmacology / MoBi

MoBi® is a software tool for multiscale physiological modeling and simulation
Other
27 stars 9 forks source link

#1369 Changing the "Merge behavior" of a module should mark the simulation as "not synched" #1387

Closed peterdew closed 1 week ago

peterdew commented 1 week ago

Fixes #1369

Description

Added SimulationStatusChangedEvents firing when modifying MergeBehavior, so diff between versions of modules are re-evaluated. Together with an issue-fix in Core ( https://github.com/Open-Systems-Pharmacology/OSPSuite.Core/issues/2271 ) to take the mergebehavior into account in the version-hash this results in a correct sync-no sync indicator.

Type of change

Please mark relevant options with an x in the brackets.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

Screenshots (if appropriate):

When the module is set to extend: image

the simulation-view looks like this: image

Questions (if appropriate):

peterdew commented 1 week ago

The two unittests for when reversing the settings are not checked on firing the event. I couldn't get it working but I think that's because the reversing is not fully implemented as fakes in the unittest. What is the importance of this?

I think in the situation where an undo is triggered it is not tested properly if the overlays are updated accordingly.