search

Open-Systems-Pharmacology / MoBi

MoBi® is a software tool for multiscale physiological modeling and simulation
Other
31 stars 10 forks source link

Load from *.pkml: show hierarchy of parameters/containers #332

Open PavelBal opened 6 years ago

PavelBal commented 6 years ago

In current implementation, the "Load from *.pkml"-dialogue shows a plaini list of all loadable components. A better way would be to show the components-tree, so the user can see the structure of the components to load. With this approach, it could also be implemented to load only selected childer of a parent-component (e.g., select "Lung" and the sub-containers "intracellular" and "interstitial", but not "blood cells" and "plasma").

msevestre commented 6 years ago

With this approach, it could also be implemented to load only selected childer of a parent-component (e.g., select "Lung" and the sub-containers "intracellular" and "interstitial", but not "blood cells" and "plasma").

I might be mistaken but I think that's already the case if you select a compartment instead of an organ no? I have never used that feature but I recall reading something in the code to that regard. Now it may also not work as documented;-)

So for me it's more like a UI work that a complete change of the logic. Do you concur? On Mon, Oct 22, 2018, 8:24 AM Pavel Balazki notifications@github.com wrote:

In current implementation, the "Load from *.pkml"-dialogue shows a plaini list of all loadable components. A better way would be to show the components-tree, so the user can see the structure of the components to load. With this approach, it could also be implemented to load only selected childer of a parent-component (e.g., select "Lung" and the sub-containers "intracellular" and "interstitial", but not "blood cells" and "plasma").

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Open-Systems-Pharmacology/MoBi/issues/332, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_jVfgycocMDTVueBZmH_Gc7ZFg5D2qks5unbjigaJpZM4XzSM- .

PavelBal commented 6 years ago

Changing the GUI would be sufficient.

This is how it works now:

Here we can see the first problem - "Molecule properties" is present multiple times, but it is not clear what the differences are. It is even more confusing for other building blocks (especially "Events"). I would prefer a tree-view similar to that seen in simulation-view:

image

Also, to make it more obvious that all children of a selected entry are loaded, the child-entries can be marked as selected (grey background) automatically. So, in case I select "Lung", the viel would be like this: image

If I select "Intracellular", the view would be like

image