Closed PavelBal closed 2 years ago
Dead links: FILE: ./Ethinylestradiol/Ethinylestradiol-Report.md [✖] link → Status: 400 [Error: ENOENT: no such file or directory, access '/github/workspace/Ethinylestradiol/link'] { errno: -2, code: 'ENOENT', syscall: 'access', path: '/github/workspace/Ethinylestradiol/link' }
@PavelBal Seems not the latest version of the https://github.com/Open-Systems-Pharmacology/Evaluation-plan-template and/or of the https://github.com/Open-Systems-Pharmacology/Qualification-text-modules were used :( Because of that, many hyperlinks are not in lower case (what I mentioned in the Fluvoxamine PR), which produces a lot of false alarms with the XRefCheck-LinkChecker, making it hard to see the real broken links. Please convert the hyperlinks to lower case and recreate the reports.
Those links are invalid not only because of lower case, but because they have dots inside, which must be removed:
⛀ Anchor '2.1-Modeling-Strategy' is not present,
⛀ Anchor '2.1-modeling-strategy' is not present,
⛀ Anchor '2.2.1-In-vitro-and-physico-chemical-data' is not present,
⛀ Anchor '2.2.2-Clinical-data' is not present,
⛀ Anchor '2.2-Data' is not present,
⛀ Anchor '2.2-data' is not present,
⛀ Anchor '2.3.4-Automated-Parameter-Identification' is not present,
⛀ Anchor '2.3-Model-Parameters-and-Assumptions' is not present,
⛀ Anchor '2.3-model-parameters-and-assumptions' is not present,
⛀ Anchor '3.1-Final-Input-Parameters' is not present,
⛀ Anchor '3.1-final-input-parameters' is not present,
⛀ Anchor '3.2-Diagnostics-Plots' is not present,
⛀ Anchor '3.2-diagnostics-plots' is not present,
⛀ Anchor '3.3.1-model-building' is not present,
⛀ Anchor '3.3.1-model-verification' is not present,
⛀ Anchor '3.3-Concentration-Time-Profiles' is not present,
⛀ Anchor '3.3-concentration-time-profiles' is not present,
@PavelBal OK, I'm pausing the review now till the issues are fixed (which are mostly the same in all reports)
Range 3?
Range 3?
This is how it looks like in PK-Sim:
In the report, I just use "all plots from pk sim". So must be a problem of the reporting engine.
Zoom in ok?
and here a zoom-in would be better...
Zoom in ok?
Issue created.
and here a zoom-in would be better...
I would say it is a shortcoming of PK-Sim or the reporting engine. Using "plot all" in reporting engine it takes the limits from PK-Sim, but I cannot define the limits in PK-Sim simply because you cannot do it in popsims. Here how it looks like in PK-Sim:
I @Yuri05 adddressed yor comments.
I would say it is a shortcoming of PK-Sim or the reporting engine. Using "plot all" in reporting engine it takes the limits from PK-Sim, but I cannot define the limits in PK-Sim simply because you cannot do it in popsims. Here how it looks like in PK-Sim:
OK, I see. Seems the PK-Sim plotting engine is just more intelligent and zooms in automatically, so that <=0 values are then "skipped" What you could do:
Select a zoom rectangle with the maus
Export project to snapshot - then the axis limits will be exported.
You could also directly set the axis limits in the snapshot :) E.g. the original snapshot looks like this:
after zooming with the maus:
So in your case you could just extend the X-Axis settings with XMin in the snapshot - and hope, that RE interprets it properly :)
...
},
"XAxisSettings": {
"Min": 72,
"AutoRange": false
},
...
not sure if it is possible to fix: in Ethinylestradiol-Report.pdf the first glossary page is completely empty and the glossary table starts on the next page. EDIT: it's the same in all pdf reports.
@PavelBal There are few remaining typos (s. comments). After they are fixed - I think we can merge (unless you are going to fix zoom issues etc. right now)
not sure if it is possible to fix: in Ethinylestradiol-Report.pdf the first glossary page is completely empty and the glossary table starts on the next page. EDIT: it's the same in all pdf reports.
I remember I could not make it work with table spanning over multiple pages without starting it on a new page.
@Yuri05 fixed.
@Yuri05 I re-fixed the fixed that I accidentially reverted. Also removed "Source" meta data field from all observed data.
I think this can be merged now.
@PavelBal Looks good. Merging. Please adjust the model repos and creates releases ASAP
Add evaluation reports for:
Ethinylestradiol Mexiletine Moclobemide Omeprazole S-Mephenytoin Tizanidine