Open-Systems-Pharmacology / OSPSuite-R

R package for the OSPSuite
https://www.open-systems-pharmacology.org/OSPSuite-R/
Other
29 stars 12 forks source link

- Update R version used by appveyor to 4.3.3 #1397

Closed PavelBal closed 6 months ago

PavelBal commented 7 months ago

No idea if it will fix the failing unicode vignette, but lets try

Felixmil commented 7 months ago

What the hell, it worked ?

PavelBal commented 7 months ago

No it does not.. WTF

PavelBal commented 7 months ago

Since R 4.3, R "supports" unicode. This added "support" initially broke every unicode support and I remember it was tricky to get it running on Windows.

R's locale options on AppVeyor:

locale:
[1] LC_COLLATE=English_United States.1252 
[2] LC_CTYPE=English_United States.1252   
[3] LC_MONETARY=English_United States.1252
[4] LC_NUMERIC=C                          
[5] LC_TIME=English_United States.1252 

On my machine:

> Sys.getlocale()
[1] "LC_COLLATE=English_Germany.utf8;LC_CTYPE=English_Germany.utf8;LC_MONETARY=English_Germany.utf8;LC_NUMERIC=C;LC_TIME=English_Germany.utf8"

So we have to enforce UTF-8 on AppVeyors R installation. @Felixmil any idea how?

Yuri05 commented 7 months ago
I always knew it... =
Felixmil commented 7 months ago

More like: =

PavelBal commented 7 months ago

I give up.

Yuri05 commented 7 months ago

I give up.

Never ever give up 😄

For now I would suggest to rewrite the test avoiding the problematic units. For later: maybe we need to do the same for ² etc. what we did for µ. R+Unicode+Windows is a nightmare