search

Open-Systems-Pharmacology / OSPSuite-R

R package for the OSPSuite
https://www.open-systems-pharmacology.org/OSPSuite-R/
Other
29 stars 12 forks source link

Add documentation how to vary RHS params in SimulationBatch #1398

Closed PavelBal closed 6 months ago

PavelBal commented 7 months ago

Proposal from @rwmcintosh - add a new argument stateVariableParams to the function, so createSimulationBatch(simulation, parametersOrPaths = NULL, stateVariableParamsOrPaths = NULL, moleculesOrPaths = NULL).

@msevestre @Yuri05 what do you think?

Yuri05 commented 7 months ago

Proposal from @rwmcintosh - add a new argument stateVariableParams to the function, so createSimulationBatch(simulation, parametersOrPaths = NULL, stateVariableParamsOrPaths = NULL, moleculesOrPaths = NULL).

@msevestre @Yuri05 what do you think?

why not

EDIT: I changed my mind :) https://github.com/Open-Systems-Pharmacology/OSPSuite-R/issues/1400#issuecomment-2074587306

PavelBal commented 7 months ago

Proposal from @rwmcintosh - add a new argument stateVariableParams to the function, so createSimulationBatch(simulation, parametersOrPaths = NULL, stateVariableParamsOrPaths = NULL, moleculesOrPaths = NULL).

I realized this is not that straightforward. SimulationBatch$addRunValues() supports adding values for parameters and initial values of molecules, and RHS params should be in the molecules list. If we want to extend the createSimulationBatch function by the argument for state variable parameters, addRunValues should support this too, but this is implemented in .NET. IMO too much overhead for now.

PavelBal commented 6 months ago

@Yuri05 @msevestre @Felixmil pls review