search

Open-Systems-Pharmacology / OSPSuite-R

R package for the OSPSuite
https://www.open-systems-pharmacology.org/OSPSuite-R/
Other
29 stars 12 forks source link

Tests are missing in the Linux package #1478

Closed Yuri05 closed 3 months ago

Yuri05 commented 3 months ago

Testthat tests are missing in the Linux package

Felixmil commented 3 months ago

What do you mean ? Tests are not supposed to be present in packaged packages:

PavelBal commented 3 months ago

I think we had this discussion already :) Actually for validation purposes, supplying the tests with the package would be a good idea. Is this doable?

Felixmil commented 3 months ago

This is possible with an installation option:

devtools::install_github("tidyverse/ggplot2", INSTALL_opts = "--install-tests")
testthat::test_package("ggplot2")

But I can also change the building workflow to include tests with:

devtools::build(...,  args=c("--preclean", "--install-tests"))

This way, user can test package installed from binary

Yuri05 commented 3 months ago

But I can also change the building workflow to include tests with:

devtools::build(...,  args=c("--preclean", "--install-tests"))

Please do. Having testthat-tests included in (at least) the Linux version is mandatory on our side due to the internal package validation procedure.

Felixmil commented 3 months ago

Proposed in this PR