Observed data: extended properties without name

Yuri05 commented 5 months ago

It happens from time to time that serialized observed data sets have extended properties without a name:

...
  <ExtendedProperties>
    ...
    <StringExtendedProperty readOnly="0" />
  </ExtendedProperties>
...

s e.g.

In such a case, the whole project cannot be loaded at all. While the problem (during observed data import?) is still not reproducible, we could try to catch it somewhere.

e.g. additionally to the value, check that the name of the extended property is not null or empty before adding it? https://github.com/Open-Systems-Pharmacology/OSPSuite.Core/blob/0d01657eb8defd5501d25ffbcf21c26fa1869a06/src/OSPSuite.Infrastructure.Import/Core/Mappers/DataSetToDataRepositoryMapper.cs#L39-L44
or adjust the onMissingKey argument when adding an extended property (so that if the name is null or empty it will be replaced with some dummy name)? Does not make much sense but at least it would not crash https://github.com/Open-Systems-Pharmacology/OSPSuite.Core/blob/0d01657eb8defd5501d25ffbcf21c26fa1869a06/src/OSPSuite.Core/Domain/ExtendedProperties.cs#L9

Yuri05 commented 5 months ago

@msevestre @rwmcintosh Thoughts on this?

rwmcintosh commented 5 months ago

Dummy name would at least prevent it from being lost during import. Can the name be changed after?

Yuri05 commented 5 months ago

If it's not one of the predefined names (e.g. "Organ", "Molecule") - yes, it can be changed later.

Open-Systems-Pharmacology / OSPSuite.Core

Observed data: extended properties without name #2231