I needed to do some refactoring so that the differences in MoBi and PK-Sim approaches can be both accommodated. In PK-Sim this presenter is usually as a TableParameter implying that there's always a parameter attached. In MoBi we do not always have access to the formula owner.
There are some fields that it is not possible to edit in PK-Sim, where they are exposed in MoBi.
In MoBi, the user is directly editing the domain object in the building block. In PK-Sim, it seems this formula is cloned, edited as a clone, and then the original formula replaced.
There should be no behavioural changes in PK-Sim as a result of this refactor.
Type of change
Please mark relevant options with an x in the brackets.
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires documentation changes (link at least one user or developer documentation issue):
[ ] Algorithm update - updates algorithm documentation/questions/answers etc.
[ ] Other (please describe):
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
[ ] Integration tests
[x] Unit tests
[x] Manual tests
[ ] No tests required
Reviewer checklist
Mark everything that needs to be checked before merging the PR.
[ ] Check if the code is well documented
[ ] Check if the behavior is what is expected
[ ] Check if the code is well tested
[ ] Check if the code is readable and well formatted
[ ] Additional checks (document below if any)
[ ] Check if documentation update issue(s) are created if the option This change requires a documentation update above is selected
Fixes #2301
Description
I needed to do some refactoring so that the differences in MoBi and PK-Sim approaches can be both accommodated. In PK-Sim this presenter is usually as a TableParameter implying that there's always a parameter attached. In MoBi we do not always have access to the formula owner.
There are some fields that it is not possible to edit in PK-Sim, where they are exposed in MoBi.
In MoBi, the user is directly editing the domain object in the building block. In PK-Sim, it seems this formula is cloned, edited as a clone, and then the original formula replaced.
There should be no behavioural changes in PK-Sim as a result of this refactor.
Type of change
Please mark relevant options with an
xin the brackets.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Reviewer checklist
Mark everything that needs to be checked before merging the PR.
This change requires a documentation updateabove is selectedScreenshots (if appropriate):
Questions (if appropriate):