Description

Add serialization property IsPKSimModule so that it can set on PkSim export and used in Mobi Import and change.

Type of change

Please mark relevant options with an x in the brackets.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires documentation changes (link at least one user or developer documentation issue):
[ ] Algorithm update - updates algorithm documentation/questions/answers etc.
[ ] Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Integration tests
[ ] Unit tests
[x] Manual tests
[ ] No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

[ ] Check if the code is well documented
[ ] Check if the behavior is what is expected
[ ] Check if the code is well tested
[ ] Check if the code is readable and well formatted
[ ] Additional checks (document below if any)
[ ] Check if documentation update issue(s) are created if the option This change requires a documentation update above is selected

Screenshots (if appropriate):

Questions (if appropriate):

msevestre commented 3 months ago

Can you add the number being fixed please ? Otherwise the issue isn’t closed automatically

PavelBal commented 3 months ago

I don’t know what the first issue is about so I am not sure what constitute a PK-sim module

The original issue is about changing this property:

Should not convert a PK-Sim module to an extension module.

Yuri05 commented 3 months ago

I assume, with this change PK-Sim has to set module.IsPKSimModule = true before exporting a module? Do we have an issue for this in the PK-sim repo?

benjaperez1983 commented 3 months ago