Well this was a tricky one! As I expected, the issue is because we are updating a NON_DISTRIBUTED Parameter by a DISTRIBUTED_PARAMETER. it works if the parameter does not exist because it's created. But in the case outlined by @PavelBal , the parameter was created by the other Module and therefore the update routine did not work. This PR removes the existing parameters if they don't have the same structure and add them again
Spent most of the time trying to reproduce the bug.. as always :)
Type of change
Please mark relevant options with an x in the brackets.
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires documentation changes (link at least one user or developer documentation issue):
[ ] Algorithm update - updates algorithm documentation/questions/answers etc.
[ ] Other (please describe):
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
[ ] Integration tests
[ ] Unit tests
[ ] Manual tests
[ ] No tests required
Reviewer checklist
Mark everything that needs to be checked before merging the PR.
[ ] Check if the code is well documented
[ ] Check if the behavior is what is expected
[ ] Check if the code is well tested
[ ] Check if the code is readable and well formatted
[ ] Additional checks (document below if any)
[ ] Check if documentation update issue(s) are created if the option This change requires a documentation update above is selected
…d parameters
Fixes #2331
Description
Well this was a tricky one! As I expected, the issue is because we are updating a NON_DISTRIBUTED Parameter by a DISTRIBUTED_PARAMETER. it works if the parameter does not exist because it's created. But in the case outlined by @PavelBal , the parameter was created by the other Module and therefore the update routine did not work. This PR removes the existing parameters if they don't have the same structure and add them again
Spent most of the time trying to reproduce the bug.. as always :)
Type of change
Please mark relevant options with an
xin the brackets.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Reviewer checklist
Mark everything that needs to be checked before merging the PR.
This change requires a documentation updateabove is selectedScreenshots (if appropriate):
Questions (if appropriate):