Fixes #2358 It should not be possible to create a simulation with multiple identical neighborhoods

[rwmcintosh]

Fixes #2358

Description

It's possible that two modules could define different neighborhoods that connect the same containers. This prevents the simulation from being created.

Type of change

Please mark relevant options with an x in the brackets.

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires documentation changes (link at least one user or developer documentation issue):
• [ ] Algorithm update - updates algorithm documentation/questions/answers etc.
• [ ] Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• [ ] Integration tests
• [x] Unit tests
• [x] Manual tests
• [ ] No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

• [ ] Check if the code is well documented
• [ ] Check if the behavior is what is expected
• [ ] Check if the code is well tested
• [ ] Check if the code is readable and well formatted
• [ ] Additional checks (document below if any)
• [ ] Check if documentation update issue(s) are created if the option This change requires a documentation update above is selected

Screenshots (if appropriate):

Questions (if appropriate):

[rwmcintosh]

actually, I think the full path is needed rather than just the names.

[rwmcintosh]

actually, I think the full path is needed rather than just the names.

ok, it is this way already, in this simple example, the paths are only one element deep.

[rwmcintosh]