search

Open-Systems-Pharmacology / OSPSuite.FuncParser

Function parser for numeric and logic expressions used by the Open Systems Pharmacology Suite
Other
0 stars 3 forks source link

Use `cmath` for `Math` on both Windows and Linux #51

Closed IndrajeetPatil closed 2 years ago

IndrajeetPatil commented 2 years ago

Closes #50

IndrajeetPatil commented 2 years ago

I will mark this "Ready for review" when I manage to add tests. Need to figure how to do it first 😅

IndrajeetPatil commented 2 years ago

I thought this covered the code in question, but probably not:

https://github.com/Open-Systems-Pharmacology/OSPSuite.FuncParser/blob/532b6d8cc52f67dccefbc794dd7175f62d86c099/tests/TestFuncParserCPP/TestFuncParser.cpp#L60-L70

Yuri05 commented 2 years ago

I thought this covered the code in question, but probably not:

No, this is just a small command line app for interactive tests and e.g. for memory/performance profilers etc. It is neither compiled nor executed on AppVeyor.

As @msevestre said (s. https://github.com/Open-Systems-Pharmacology/OSPSuite.FuncParser/issues/50#issuecomment-1084961036) all tests are part of OSPSuite.FuncParser.Tests project, which is included into the "main solution OSPSuite.FuncParser.sln If you open the solution in Visual Studio, you can run all the tests either via Resharper or via VS built-in test runner

IndrajeetPatil commented 2 years ago

Closing this as I won't be able to add any tests.