search

Open-Systems-Pharmacology / OSPSuite.RUtils

Utility functions for Open Systems Pharmacology R packages
https://www.open-systems-pharmacology.org/OSPSuite.RUtils/dev/
GNU General Public License v2.0
1 stars 3 forks source link

Adds `ifEqual()` and `ifIncluded()` #115

Closed IndrajeetPatil closed 2 years ago

IndrajeetPatil commented 2 years ago

Closes #114

codecov-commenter commented 2 years ago

Codecov Report

Merging #115 (767467e) into develop (e908c9b) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #115      +/-   ##
===========================================
+ Coverage    99.42%   99.44%   +0.01%     
===========================================
  Files           17       18       +1     
  Lines          174      180       +6     
===========================================
+ Hits           173      179       +6     
  Misses           1        1
Impacted Files Coverage Δ
R/utilities.R 100.00% <ø> (ø)
R/utilities-conditional.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e908c9b...767467e. Read the comment docs.

IndrajeetPatil commented 2 years ago

I am not even sure if we need these functions.

Removing them from tlf (https://github.com/Open-Systems-Pharmacology/TLF-Library/pull/299) and reporting engine (https://github.com/Open-Systems-Pharmacology/OSPSuite.ReportingEngine/pull/818) makes no difference. So I don't think they are being used anywhere.

Up to you if you want to include them anyway.