Closed rengelke closed 6 months ago
@rengelke Please add a short description of the new function in the first comment (just copy-paste from the documentation and an example).
Please add an entry to the NEWS
file
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.69%. Comparing base (
64bc87c
) to head (7e38f91
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
this function could be very useful to validate a whole dataframe column (or even dataframe)?. Would this work (i.e have vectors in inputOptions) ?
Also, did you take into account NULL or NAs ? Maybe allowing empty values could be an option in some cases ?
it seems that Ubuntu18 runner images are not supported by GitHub anymore (that's why the 3 Ubuntu18 jobs are still pending) https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories
this function could be very useful to validate a whole dataframe column (or even dataframe)?. Would this work (i.e have vectors in inputOptions) ?
Also, did you take into account NULL or NAs ? Maybe allowing empty values could be an option in some cases ?
Great idea about extending it to dataframes. It's totally doable with a few tweaks to make it more modular and flexible. We can definitely make it work for a column or dataframe.
About the NULL and NAs, I didn't focus much on them since we were validating options, where it wasn't so crucial. But including them makes a lot of sense for broader use.
I will get those changes done and commit..
@rengelke Whats the status of this one?
validateIsOption()
to validate a list of options against specified criteria, improving robustness in option handling. This function ensures options match expected types, value ranges, allowed values, and handlesNULL
andNA
values.validateColumns()
for rigorous validation of data frame columns against predefined specifications. Supports validation of type, value range, allowed values, and managesNULL
andNA
values effectively.validateVector()
introduced as a comprehensive vector validation tool, allowing checks against type, value range, and predefined allowed values with considerations forNULL
andNA
. Used by other validation functionsvalidateIsOption()
andvalidateColumns()
.validateVectorRange()
andvalidateVectorValues()
to provide detailed validation for value ranges and allowed values respectively. These functions complementvalidateVector()
.