Open-Systems-Pharmacology / OSPSuite.ReportingEngine

R implementation of the reporting engine
https://www.open-systems-pharmacology.org/OSPSuite.ReportingEngine/
Other
5 stars 5 forks source link

Crash of PlotPKParameter because of different outputs in simulations #1209

Closed KatrinCoboeken closed 4 months ago

KatrinCoboeken commented 6 months ago

In my example I have a workflow with simulations with one out put and simulations with two outputs. That crashes in the function validateSameOutputsBetweenSets in the line "if (all(pkParametersTable$path == pkParametersTableRef$path)) " as the data.frames have a different size, "==" does not work. The error message is "longer object length is not a multiple of shorter object length"

But why do we have this condition on same outputs between sets. We produce one plot per simualtion and output. I do not see a reason why we can not mix simulations with different output numbers. Also the number of PK Parameter per output shoudn't be an issue. Why can we not have some plots with e.g. 6 simulations on the x-axis, and some with e.g. 4?

Yuri05 commented 6 months ago

@KatrinCoboeken Questions:

KatrinCoboeken commented 6 months ago

I would not produce warnings. I think it is a common case. Eg if we have for some studies mesaurements of parent and metabolites and for some only of parent.

If 2 sets have no common output at all, then we get the plots for set 1 with the outputs of set 1 and the plots for set 2 with the outputs of set 2

Yuri05 commented 5 months ago