Open-Systems-Pharmacology / OSPSuite.ReportingEngine

R implementation of the reporting engine
https://www.open-systems-pharmacology.org/OSPSuite.ReportingEngine/
Other
5 stars 5 forks source link

CL unit in PKRatio qualification plots #1242

Closed pchelle closed 4 months ago

pchelle commented 4 months ago

@Yuri05 while running the tests for qualification workflows, I encountered the error below

Unit 'l/h' is not included in available units for dimension: 'Flow per weight'.

the error comes from a difference between

ospsuite::pkParameterByName("CL")
#> PKParameter: 
#>    Name: CL 
#>    DisplayName: Total body clearance/F 
#>    Dimension: Flow per weight 
#>    DisplayUnit: ml/min/kg

Created on 2024-07-03 with reprex v2.0.2

Since the display name and unit from {ospsuite} are confusing (the word "total" is misleading), Can you let me know if I should fix the Reporting Engine CL as a Flow per weight ?

Yuri05 commented 4 months ago

You mean this I guess: https://github.com/Open-Systems-Pharmacology/OSPSuite.ReportingEngine/blob/e8a9ccaf75a02c0bf48a2a5067de9d4d8d7a42db/R/utilities-task.R#L1080-L1083

I am surprised that the CL unit is defined this way, especially because CL was already used in many qualification reports and the output was always in e.g. [ml/min/kg] (e.g. compare https://github.com/Open-Systems-Pharmacology/OSP-Qualification-Reports/blob/master/Pediatric_Qualification_Package_GFR_Ontogeny/report.md#evaluation-of-pediatric-translation).

So yes, please change the dimension to flow per weight and set the unit to ml/min/kg