Open-Systems-Pharmacology / OSPSuite.ReportingEngine

R implementation of the reporting engine
https://www.open-systems-pharmacology.org/OSPSuite.ReportingEngine/
Other
5 stars 5 forks source link

pop pk plot for >1 PopulationSimulationSets #174

Closed Yuri05 closed 4 years ago

Yuri05 commented 4 years ago

In the example attached there are 2 populations sets: one with the set name "10mg" and another one with the set name "25 mg". Test06.zip

PopulationSimulationSets definition ``` popSimSet1 <- PopulationSimulationSet$new( simulationFile = file.path(pkmlDir, "Raltegravir 10 mg (lactose formulation).pkml"), populationFile = file.path(inputDir, "Raltegravir Adult Population.csv"), pathID = "Organism|Heart|Plasma|Raltegravir|Concentration", pathName = "Raltegravir Heart", pathUnit = "µg/l", pkParameters = c("C_max", "t_max"), pkParametersUnits = c("µg/l", "h"), simulationSetName = "10mg" ) popSimSet2 <- PopulationSimulationSet$new( simulationFile = file.path(pkmlDir, "Raltegravir 25 mg (lactose formulation).pkml"), populationFile = file.path(inputDir, "Raltegravir Adult Population.csv"), pathID = "Organism|Heart|Plasma|Raltegravir|Concentration", pathName = "Raltegravir Heart", pathUnit = "µg/l", pkParameters = c("C_max", "t_max"), pkParametersUnits = c("µg/l", "h"), simulationSetName = "25 mg" ) ```

In this case the expectation for pk parameters box-whisker plots is: for each combination of {PK-Parameter; Output} one plot with 2 boxes is created (one box per PopulationSimulationSet}

However there is only 1 box per plot created: AUC_inf But it should be something like this: grafik (s. also Matlab-Example reports, e.g. https://github.com/Open-Systems-Pharmacology/Reporting-Engine/blob/develop/advanced_examples/03_Population_Pediatric_Raltegavir/figures/pKParameter_Appendix.docx chapter 1.5)

Seems that pk values are grouped by the population name (which in this example is the same for both PopulationSimulationSets) and not by PopulationSimulationSets

Yuri05 commented 4 years ago

s. also https://github.com/Open-Systems-Pharmacology/OSPSuite.ReportingEngine/issues/175

pchelle commented 4 years ago

@Yuri05 here is the update using the new Output class

A few remarks:

Yuri05 commented 4 years ago

@pchelle Great!

Regarding the question:

Currently the selection of PK parameters to plot is handled that way, Let me know if you prefer this to be included in Output popWorkFlow$plotPKParameters$yParameters <- c("C_max", "t_max")

Yes, let's include PK-Parameters in the output definition!