Open-Systems-Pharmacology / OSPSuite.ReportingEngine

R implementation of the reporting engine
https://www.open-systems-pharmacology.org/OSPSuite.ReportingEngine/
Other
5 stars 5 forks source link

Missing plots #605

Closed Yuri05 closed 2 years ago

Yuri05 commented 3 years ago

Based on https://github.com/pchelle/Test-of-Pediatric-Qualification-Workflow/blob/main/Report.md

2 last plots are missing in the report - compare Matlab report: grafik

pchelle commented 2 years ago

The population file was not output by the qualification runner. I thought I had the right versions, don't I ? (QualificationRunner10.0.55 and PK-Sim10.0.251)

Yuri05 commented 2 years ago

The latest versions are:

Please check if you still the problem with the latest versions

pchelle commented 2 years ago

@Yuri05 The correct version of the Qualification Runner worked but the population time profiles are currently not run. The reason is that I am currently throwing a warning and skip the plot if its Axes Properties are not defined (btw, let me know if this should be an error instead). I had hoped that Population time profiles had a similar definition of axes compared to other plots, but it is not the case:

Would it be possible to export the axes settings for population time profiles the same way as they are done for mean time profiles ?

Yuri05 commented 2 years ago

Would it be possible to export the axes settings for population time profiles the same way as they are done for mean time profiles ?

The problem is that those settings currently cannot be defined in PK-Sim at all for pop simulations: https://github.com/Open-Systems-Pharmacology/PK-Sim/issues/1546 https://github.com/Open-Systems-Pharmacology/PK-Sim/issues/1547

So fixing might be a bigger effort. Can you take for the population plots the global time profile axes settings and overwrite only those axis settings which are found in the configuration of a population plot?

pchelle commented 2 years ago

Can you take for the population plots the global time profile axes settings and overwrite only those axis settings which are found in the configuration of a population plot?

I can but I haven't seen any global axes settings for time profile. So currently, for the pediatric example, the config plan does not provide the unit, dimension or scale for the x axis.

Yuri05 commented 2 years ago

I can but I haven't seen any global axes settings for time profile.

True... We could introduce TimeProfile axes settings then. However I would make them optional, otherwise all current qualification plans would become invalid and must be adjusted. So I would suggest (to be discussed):

How did actually the Matlab-RE deal with this situation?

pchelle commented 2 years ago

How did actually the Matlab-RE deal with this situation?

Option 2 was used then in runQualificationWorkflow.m