Memory leaks in SimModel when running Sensitivity Analysis

msevestre commented 7 years ago

Steps to reproduce:

Run sensitivity for a standard PK-Sim Model in MoBi (Diclofenac for example)
Select ALL parameters for the sensitivity (Advanced mode and select all parameters)
Run sensitivity
The memory usage gets very high, and much higher than just the amount of data saved by managed .NET
The time to run simulations increases with time!!

msevestre commented 7 years ago

As soon as the sensitivity is finsihed, the following occurs

Memory goes down to 400 MB (e.g. memory leaks definitely in the calculation)
results are ignored in MoBi. Something crashes silently and it looks like the sensitivity was not run

Yuri05 commented 7 years ago

why do u think this is SimModel-Leak?

msevestre commented 6 years ago

@Yuri05 Because There is no .NET code in between..really

Yuri05 commented 6 years ago

@msevestre Do you observe memory leaks also in population simulations? From SimModel's perspective it's the same use case.

msevestre commented 6 years ago

@Yuri05 I have only make this observation with Sensitivity but haven't checked for population.

msevestre commented 6 years ago

I have described all steps above however. Can't you reproduce it ?

Yuri05 commented 6 years ago

I have described all steps above however. Can't you reproduce it ?

It seems that there are memory leaks indeed. But not sure if the problem is in SimModel.

E.g. in the project attached (where SA was already calculated, ca. 5650 simulations): 4.34_Opti.mbp3.zip

Open project, Open SA, perform GC: memory usage ca. 348MB
Run SA, perform GC: memory usage ca. 367MB
Run SA again, perform GC: memory usage ca. 377MB
Run SA again, perform GC: memory usage ca. 378MB

Having SA already calculated, I would expected nearly the same usage in 1-4 (348MB)

I also do not observe SA becoming slower with every execution.

msevestre commented 6 years ago

64 bit might change the whole observations. I'd try to reproduce it with 7.3 if I were you

On Wed, Nov 28, 2018 at 12:31 PM Juri Solodenko notifications@github.com wrote:

I have described all steps above however. Can't you reproduce it ?

It seems that there are memory leaks indeed. But not sure if the problem is in SimModel.

E.g. in the project attached (where SA was already calculated, ca. 5650 simulations): 4.34_Opti.mbp3.zip https://github.com/Open-Systems-Pharmacology/OSPSuite.SimModel/files/2625911/4.34_Opti.mbp3.zip

Open project, Open SA, perform GC: memory usage ca. 348MB

Run SA, perform GC: memory usage ca. 367MB

Run SA again, perform GC: memory usage ca. 377MB

Run SA again, perform GC: memory usage ca. 378MB

Having SA already calculated, I would expected nearly the same usage in 1-4 (348MB)

I also do not observe SA becoming slower with every execution.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Open-Systems-Pharmacology/OSPSuite.SimModel/issues/19#issuecomment-442534496, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_jVYL9aW3SKCF3yZ5RnP7TovSMMA0hks5uzshqgaJpZM4PKZjH .

Yuri05 commented 6 years ago

Cannot find any leakss in SimModel. Also unable to reproduce the behaviour with Mobi 7.4.

Reopen if you can reproduce with 7.4 (in this case we should perform .NET profiling first)

Open-Systems-Pharmacology / OSPSuite.SimModel

Memory leaks in SimModel when running Sensitivity Analysis #19