search

Open-Systems-Pharmacology / OSPSuite.SimModel

Calculation engine for models built with PK-Sim® or MoBi®
Other
5 stars 3 forks source link

Fix #33 changed scale factors are not updated in xml #34

Closed PavelBal closed 6 years ago

PavelBal commented 6 years ago

Calling Simulation.GetSimulationXMLString() now updates the scale factors of the species.

msevestre commented 6 years ago

@PavelBal Thanks for this. There is one issue with the PR: It contains the code for other fixes (commit ed8ebbf and 09e1a28)

Can you create another PR based off the master branch and only use 08a4f8d

An easy way to do it is:

git checkout master 
git pull origin master (make sure you are uptodate with this repo. Maybe your remote is not called origin. Depends on how you defined it)
git checkout -b 33-change-scale-factor
git cherry-pick 08a4f8d

Then push to your repo and create your PR. That way, your PR will only have one commit

Thanks :)