CodeRefactoring: Follow up of #38 C++ export from SimModel:

Open-Systems-Pharmacology / OSPSuite.SimModel

Calculation engine for models built with PK-Sim® or MoBi®

Other

5 stars 3 forks source link

CodeRefactoring: Follow up of #38 C++ export from SimModel: #41

Open msevestre opened 6 years ago

msevestre commented 6 years ago

As pointed out in PR in #39 and #40, the code implemented does not respect many of our basic coding standards. Moreover some encapsulation is clearly broken when accessing private member of another instances etc..

All of that can and should be updated before implementing even more code that does not respect our coding standards.

msevestre commented 6 years ago

see https://github.com/Open-Systems-Pharmacology/OSPSuite.SimModel/issues/38 for original issue