search

Open-Systems-Pharmacology / PK-Sim

PK-Sim® is a comprehensive software tool for whole-body physiologically based pharmacokinetic modeling
Other
102 stars 50 forks source link

Attention: Misleading/missing application feedback in selection of enzymes from DB #1009

Open ju-rgen opened 5 years ago

ju-rgen commented 5 years ago

When selecting enzymes from the DB (e.g. ABCB1) in the displayed list the bottom entry is "highlighted" by gray background color. When selecting the top entry it is not clearly marked/highlighted except for a slightly visible frame. After pressing next it is not visible, which enzyme is shown. This behaviour could lead to mistakes in the selection. (In particular, if the same name is used for two entries) grafik grafik grafik grafik

ju-rgen commented 5 years ago

See TC 77.3

Yuri05 commented 5 years ago

@ju-rgen Window height should be increased in this case - protein name will be shown above the expression diagram. grafik

msevestre commented 5 years ago

I'd say that there is nothing to change here. In general, the view is bigger as we assume that people are actually going to look at what's going on. Please reopen if you think we need to do anything

PavelBal commented 5 years ago

I agree with @ju-rgen , the protein selection UI is misleading (imo). One issue is the poor highlighting of the selected entry.

Another issue is the generally unintuitive list of search results. E.g., in the case of "ABCB1", there are two entries with the same gene name (the first two). However, they represent two different genes - ABCB1 and ABCB4! The "Name Type" column is not clear to me.

Also it is misleading, as the tab is called "Protein Selection", but the user actually selects the gene (makes sense as it es a gene expression database). Also, it would be good to also show a column with all other names that lead to this entry. E.g., in case of ABCB1, the same gene can be found by searching for "p-gp".

image

However, these are the same entires. Also, "P-GP" is listed as "Gene name", which is wrong - the gene is still ABCB1.

msevestre commented 5 years ago

@pavelbal a lot of issues in one single entry! They will all get lost. Would you please open one issue for each point that you wrote? I think those are all valid points Indeed.

This issue here is about selection. Clearly the first view should have better highlighting. Let's keep the focus on this idea here. Going to reopen

Yuri05 commented 5 years ago

@PavelBal s. also discussions in #966 and #946