search

Open-Systems-Pharmacology / PK-Sim

PK-Sim® is a comprehensive software tool for whole-body physiologically based pharmacokinetic modeling
Other
103 stars 50 forks source link

Dead code (non-existing compound process groups) #2300

Open Yuri05 opened 2 years ago

Yuri05 commented 2 years ago

It seems that there are no processes with the group "IN_VITRO_PROCESSES_ENZYMATIC_STABILITY" and "IN_VITRO_PROCESSES_TOTAL_HEPATIC"

and the following code lines are never executed

https://github.com/Open-Systems-Pharmacology/PK-Sim/blob/ec53f4f8e519ac4ffc9ca064d4435620eca55fd0/src/PKSim.Infrastructure/ORM/Mappers/FlatProcessToCompoundProcessMapper.cs#L50-L51

https://github.com/Open-Systems-Pharmacology/PK-Sim/blob/ec53f4f8e519ac4ffc9ca064d4435620eca55fd0/src/PKSim.Infrastructure/ORM/Mappers/FlatProcessToCompoundProcessMapper.cs#L59-L60

The 3 in vitro groups seems also to be unused in the database and can be removed grafik

StephanSchaller commented 2 years ago

Not so quick :-) ... we still want to include further in.vitro data: https://github.com/Open-Systems-Pharmacology/PK-Sim/issues/1489

or am I mixing sth up?

msevestre commented 2 years ago

hum...