Open-Systems-Pharmacology / PK-Sim

PK-Sim® is a comprehensive software tool for whole-body physiologically based pharmacokinetic modeling
Other
98 stars 49 forks source link

Commit ID included in version strings #2887

Closed rwmcintosh closed 2 months ago

rwmcintosh commented 3 months ago

There's some additional stuff in the splash screen and also in the title bar when running a non-release build image

We are generating this through some built-in attributes of the assembly when non-release

      private string retrieveReleaseDescription()
      {
         var informationalVersionAttribute = Assembly.GetEntryAssembly()
            ?.GetCustomAttributes(typeof(AssemblyInformationalVersionAttribute), inherit: false)
            .OfType<AssemblyInformationalVersionAttribute>()
            .FirstOrDefault();

         return string.IsNullOrEmpty(informationalVersionAttribute?.InformationalVersion) ? FullVersion : informationalVersionAttribute.InformationalVersion;
      }

This was introduced in an SDK update and an issue registered and documented

When I add the attribute to the PKSim.csproj in a PropertyGroup, then we get the old behavior.

<IncludeSourceRevisionInInformationalVersion>false</IncludeSourceRevisionInInformationalVersion>

image

To be investigated, is this only a problem in non-release builds? Or do we need to fix this?