Closed rwmcintosh closed 2 months ago
There's some additional stuff in the splash screen and also in the title bar when running a non-release build
We are generating this through some built-in attributes of the assembly when non-release
private string retrieveReleaseDescription() { var informationalVersionAttribute = Assembly.GetEntryAssembly() ?.GetCustomAttributes(typeof(AssemblyInformationalVersionAttribute), inherit: false) .OfType<AssemblyInformationalVersionAttribute>() .FirstOrDefault(); return string.IsNullOrEmpty(informationalVersionAttribute?.InformationalVersion) ? FullVersion : informationalVersionAttribute.InformationalVersion; }
This was introduced in an SDK update and an issue registered and documented
When I add the attribute to the PKSim.csproj in a PropertyGroup, then we get the old behavior.
PropertyGroup
<IncludeSourceRevisionInInformationalVersion>false</IncludeSourceRevisionInInformationalVersion>
To be investigated, is this only a problem in non-release builds? Or do we need to fix this?
There's some additional stuff in the splash screen and also in the title bar when running a non-release build![image](https://github.com/Open-Systems-Pharmacology/PK-Sim/assets/261477/0337eec7-cb3a-4c11-9b40-b5547efe8950)
We are generating this through some built-in attributes of the assembly when non-release
This was introduced in an SDK update and an issue registered and documented
When I add the attribute to the PKSim.csproj in a
PropertyGroup
, then we get the old behavior.<IncludeSourceRevisionInInformationalVersion>false</IncludeSourceRevisionInInformationalVersion>
To be investigated, is this only a problem in non-release builds? Or do we need to fix this?