Open-Systems-Pharmacology / PK-Sim

PK-Sim® is a comprehensive software tool for whole-body physiologically based pharmacokinetic modeling
Other
98 stars 49 forks source link

2909 create dependency resolver project and publish an artifact #2915

Open benjaperez1983 opened 2 weeks ago

benjaperez1983 commented 2 weeks ago

Fixes #2909

Description

This PR is for creating a dependency project and publish the artifacts needed to run the last PK-SIM

Type of change

Please mark relevant options with an x in the brackets.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

Screenshots (if appropriate):

Questions (if appropriate):

rwmcintosh commented 2 weeks ago

Fill in the #2909 (without space) there so that when the PR is merged, the issue is closed. Also all linking between PR and issue is made using that #

image

benjaperez1983 commented 1 week ago

@PavelBal @Yuri05 @msevestre

with this changes, we will be running a build and posting an artifact, which will be possible to download from a script in OSPSuite-R with all the dependencies needed.

Shall we run the build and publish the artifact with each merge? or whall we do it on the nightly build?

What do you guys think?

rwmcintosh commented 1 week ago

Shall we run the build and publish the artifact with each merge? or whall we do it on the nightly build?

We would only see new Core updates propagated to OSPSuite-R after a nightly, rather than on-demand. I think it's not bad if Core updates in OSPSuite-R are nightly.

rwmcintosh commented 1 week ago

@Yuri05 @msevestre @benjaperez1983 @PavelBal still a question whether we should trigger this artifact nightly, or on each PR.

I think it belongs nightly...

Yuri05 commented 1 week ago

I think it belongs nightly...

Agree.

Yuri05 commented 1 week ago

What just comes into my mind: do we need separate packages for Windows and Linux? At the moment the package contains Windows versions of all C++ libs. Is probably ok for now, but latest when we have migrated PK-Sim Core/Infrastructure to .net8 and going to use the package under Linux as well, we would need 2 separate package versions.

rwmcintosh commented 1 week ago

What just comes into my mind: do we need separate packages for Windows and Linux?

I think so, but maybe for this iteration we can consume the package as built by AppVeyor and replace the native dll as we are now.

It's probably not worth the effort until the .NET 8 upgrade is done, but we could do this in parallel if needed. I tweaked a few settings in Ubuntu and built the resolver project.

image

We would just need some alternate build configurations to pull the right native binaries