Open-Systems-Pharmacology / PK-Sim

PK-Sim® is a comprehensive software tool for whole-body physiologically based pharmacokinetic modeling
Other
103 stars 50 forks source link

Fixes #2957 Endothelial surface area "Blood flow" - wrong values in the simulation #2973

Closed rwmcintosh closed 2 weeks ago

rwmcintosh commented 2 weeks ago

Fixes #2957

Description

Removing the update of ModelProperties

Type of change

Please mark relevant options with an x in the brackets.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

Screenshots (if appropriate):

Questions (if appropriate):

rwmcintosh commented 2 weeks ago

It's very tough for me to tell if this is the right approach. It appears that the concept of updating calculation methods from a new MoleculeProperties and old MoleculeProperties is not needed now.

I tried using different species and individuals with different calculation methods and it seems like we just want to use the newly created default MoleculeProperties in all these cases.

As pointed out during our dev meeting by @msevestre this code pre-dates Open Sourcing, so there's not much history available on it.