Closed rwmcintosh closed 2 months ago
It's very tough for me to tell if this is the right approach. It appears that the concept of updating calculation methods from a new MoleculeProperties and old MoleculeProperties is not needed now.
I tried using different species and individuals with different calculation methods and it seems like we just want to use the newly created default MoleculeProperties in all these cases.
As pointed out during our dev meeting by @msevestre this code pre-dates Open Sourcing, so there's not much history available on it.
Fixes #2957
Description
Removing the update of ModelProperties
Type of change
Please mark relevant options with an
x
in the brackets.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Reviewer checklist
Mark everything that needs to be checked before merging the PR.
This change requires a documentation update
above is selectedScreenshots (if appropriate):
Questions (if appropriate):