Open-Systems-Pharmacology / PK-Sim

PK-Sim® is a comprehensive software tool for whole-body physiologically based pharmacokinetic modeling
Other
107 stars 50 forks source link

Loading from snapshot: PK-Sim silently creates healthy individuals for unknown disease states (no warning) #3021

Open Yuri05 opened 1 day ago

Yuri05 commented 1 day ago

EDIT: The problem is actually this: https://github.com/Open-Systems-Pharmacology/PK-Sim/issues/3021#issuecomment-2511350598

Initial issue description Open the snapshot in V11.3 and V12.0 (contains only 1 population simulation **based on the HI population**). Simulation results look like this (1st pic: PK-Sim **11.3**, 2nd pic: PK-Sim **12.0.390**) Snapshot and both projects (11.3 and 12.0): [42.zip](https://github.com/user-attachments/files/17977145/42.zip)
Yuri05 commented 1 day ago

Midazolam.json.zip 11.3_Midazolam.pksim5.zip 12.390_Midazolam_Full.pksim5.zip Actually, already individual simulations greatly differ (both projects again loaded from the snapshot in 11.3 and 12.0)

E.g. compare sim results in the simulation Macgilchrist1986_CPB

Yuri05 commented 1 day ago

Lol, there was no HI population in PK-Sim 11.3, so it just creates healthy individuals. So actually the only bug is that PK-Sim does not produce any warning whatsoever when creating individuals with unknown disease state (and just silently generates them as healthy). We should at least produce a warning (or maybe increment the snapshot version for V12?) {70B941A7-620D-49CA-BAE2-049EC8500680}

msevestre commented 1 day ago

Yep just wrote the same. I had the feeling this could only work in v12 not in v11.3

msevestre commented 1 day ago

(or maybe increment the snapshot version for V12?)

I don't think so. Unless you think the snapshot woul dbe loaded in an older version? In that case yes