search

Open-Systems-Pharmacology / PK-Sim

PK-Sim® is a comprehensive software tool for whole-body physiologically based pharmacokinetic modeling
Other
104 stars 50 forks source link

Observed Data import: location of error is difficult to spot in long lists #947

Closed UlrichSi closed 6 years ago

UlrichSi commented 6 years ago

When importing a list of PK data from a larger number of patients, every patient's data set needs to be strictly ordered, or the following error will be displayed:

grafik

It would be helpful if the error message would report the location of the issue in the table to make it feasible to manually correct the problem. In longer lists, it is nearly impossible to visually spot it. Currently, one has to return to Excel and add some sort of search algorithm to find it.

msevestre commented 6 years ago

Yes I had the same issues in some projects and spent quite some time finding the source of the error. While showing the exact line in the excel sheet where it happens will be with the current implementation difficult, we could very easily show which values are not monotone (e..g 5 and 4). That way the user could simply search for theses values in the excel file. Much easier :)

msevestre commented 6 years ago

@Yuri05 : I'd suggest to implement it in 7.4

UlrichSi commented 6 years ago

@msevestre This sounds fine to me, it just might result in a longer list that needs to be displayed and possibly saved for later reference, i.e., for the Excel search process.

msevestre commented 6 years ago

probably not. It would show only the first value breaking the monotonie. If there is more than one, then the data is quite corrupted indeed :)

UlrichSi commented 6 years ago

@msevestre Not necessarily quite corrupted. Imagine a set of 50-100 patients in one table, where for several patients there is one time entry duplicated to enter something other than the plasma concentration. It seems some other simulation software needs this, e.g., for entering a given dose or a measured biomarker. The see this systematic, at least a few of these issues should be displayed. Cutting the list would be probably ok.

msevestre commented 6 years ago

Fixed by #974