Open-Systems-Pharmacology / QualificationRunner

Qualification runner in charge of managing a qualification workflow
Other
0 stars 1 forks source link

Too many PKSim.CLI processes #108

Open Yuri05 opened 2 years ago

Yuri05 commented 2 years ago

When I call the qualification runner from the reporting engine with a bigger qualification plan: the number of PKSim.CLI processes launched in parallel exceeds the number of cores. E.g. I have 8 cores and when launching the CYP3A4-DDI qualification plan: 20 and sometimes even more PKSim.CLI are executed in parallel. grafik

msevestre commented 2 years ago

It is this task https://github.com/Open-Systems-Pharmacology/QualificationRunner/blob/develop/src/QualificationRunner.Core/Services/QualificationRunner.cs#L76

Is this bad? the system should be able to deal with this. Or what is your suggestion? one at a time?

Yuri05 commented 2 years ago

Not one at a time of course but the possibility to restrict the number of PKSim.CLI started in parallel. It's not bad I think (in terms of performance), the only point is that currently almost 100% CPU is consumed and users asked already in the past how the CPU usage of the quali runner can be restricted.

msevestre commented 2 years ago

I am not quite sure how to limit this. Do you want a parameter e.g. max number of cores or sthg like this. We'll need to rewrite the loop above also

Yuri05 commented 2 years ago

Yes, it would be nice to have an optional parameter Number of cores which is passed to the Qualification Runner. If not set: use MaxCores-1

msevestre commented 2 years ago

Nice as in...do it for v11 or when we have time ...