search

Open-Systems-Pharmacology / QualificationRunner

Qualification runner in charge of managing a qualification workflow
Other
0 stars 1 forks source link

Indentation changed? #116

Closed Yuri05 closed 2 years ago

Yuri05 commented 2 years ago

Compare V10 (left) vs. V11 (right):

When recreating the reports with V11 (Matlab-RE) - comparison shows that the indentaion of the Input-BBs in V11 was decreased by 1: grafik

On purpose? In V10 the indentation was correct (e.g. for a section of level 2 "Compound" was Header 3). Now in V11 is not correct anymore ("Compound starts on the level 2 as well etc.)

msevestre commented 2 years ago

@Yuri05 I just saw this one. This is probably a bug in PK-Sim...which I just released. What do we do here?

msevestre commented 2 years ago

Correction. This is estimated in the QualificatonRunner getSectionLevel I do not see anything wrong here..

msevestre commented 2 years ago

@Yuri05 Was it adjusted by hand? I don't see any differences

msevestre commented 2 years ago

this line is probablu wrong var section = sections.FirstOrDefault(x => x.Id == sectionId || x.Reference == sectionReference);

If both are null, this will probably return the section where it should return false. This needs to be changed

Yuri05 commented 2 years ago

Was it adjusted by hand? I don't see any differences

Yes. I just shifted all input subchapters by 1 level :) If it is in the QualiRunner - would be good to fix it now.