search

Open-Systems-Pharmacology / QualificationRunner

Qualification runner in charge of managing a qualification workflow
Other
0 stars 1 forks source link

Fixes #24 allow remote building blocks #26

Closed msevestre closed 5 years ago

Yuri05 commented 5 years ago

I suggest to put it on hold and NOT to merge.

I don't think it makes sense to get a building block from a remote project which is not referenced in the qualification plan. And if we would really need this: we could insert the project into the projects list of the qualification plan; after that we can use any BB from this project as before.

24 was really meant for the case that a single BB is stored in a repo on GitHub.

(also not for 7.5)

msevestre commented 5 years ago

And if we would really need this: we could insert the project into the projects list of the qualification plan; after that we can use any BB from this project as before

This is not equivalent. Any project inserted in the list will start another instance of the PKSim CLI and exports its output etc....

By using this option, you could really have one project with common building blocks that you could reference with hardly any overhead (the project is not loaded, just the snapshot).

Why not implementing it and see what people make of it?

msevestre commented 5 years ago

And it's easy to forbid by not implementing the schema change...

msevestre commented 5 years ago

I am going to merge this PR because some changes are required anyways. I'll leave the issue open and prevent loading from remote bb from hapening

Yuri05 commented 5 years ago

I'll prevent loading from remote bb from hapening

Can you explain this?

msevestre commented 5 years ago

@Yuri05 The code to load remote building block is commented out. So this won't work anymore