search

Open-Systems-Pharmacology / QualificationRunner

Qualification runner in charge of managing a qualification workflow
Other
0 stars 1 forks source link

Warning/Error if exported observed data already exists #77

Open Yuri05 opened 3 years ago

Yuri05 commented 3 years ago

If 2 PK-Sim projects include an observed data set with the same name - obsdata-set from project no. 1 will be overwritten by the obsdata-set from project no. 2 during processing of a qualification workflow.

In this case a warning should be produced. Something like: "Observed data set <Obsdata-Name> exported from the project <Project> will overwrite the file exported before. Please check you data for consistensy"

Better (but more effort): compare the data in the observed data file exported before with the observed data set which would overwrite the file. If the data is the same: just not export (no warning). If the data differs: error (stop the quali workflow)

Yuri05 commented 3 years ago

@msevestre @sfrechen FYI

msevestre commented 3 years ago

I like the better idea. Probably easy with checksum (and we have it built in already in ospsuite.utility) with the method AreFilesEqual

https://github.com/Open-Systems-Pharmacology/OSPSuite.Utility/blob/master/src/OSPSuite.Utility/FileHelper.cs#L186

I implemented it years ago and never managed to find a good use case...until NOW)

sfrechen commented 3 years ago

A comparison would be helpful in the current situtation where we have multiple duplicates (victim control datasets are duplicated by default right now).