473 improve handling of loooooong plot and grid titles

[Felixmil]

We can now use insanely long strings for labels and legend without overflow outside of the plot and plotgrids

• Use ggtext::element_textbox() instead of ggplot2::element_text() for theming labels (titles, subtitles, caption and axis titles)
• No changes for axis text, watermark and legends except the addition of a small margin
• New ENUM describing the valid text "orientations" for labels,
• Update minimal-theme
• Use ggtext and stringr as new dependency (both validated)

Warning A lot of snapshots will break on ospsuiteR

[Felixmil]

For some reason, the factor order for groups is different in local than appveyor, causing the build to fail.

Appveyor's snapshot:

Local's snapshot:

@pchelle any idea why it does that ?

[pchelle]

* Use ggtext and stringr as new dependency (both validated)

I did not know that ggtext was already validated. If so, that means we could include markdown content within plots ! :) But we would need to spread all this to the other texts/labels (e.g. axis.text, axis.title, etc.) correct ?

[pchelle]

A lot of snapshots will break on ospsuiteR

Potentially also on Reporting Engine. Not sure if this will crash or not some plots or change their look. I also don't know how the translation of the fonts from showtext will perform.

[pchelle]

@pchelle any idea why it does that ?

One of my guesses is that depending on one or some of the versions of your packages, the legend ordering may be different as it already happened for ggplot2 version 3.3.0 (see below)

https://github.com/Open-Systems-Pharmacology/TLF-Library/blob/daea5899dbcb989a6c9f7be15d4b1a319a18f635/R/utilities-legend.R#L166

A smart R6 object might be a solution to better handle legends through guides and scales.

[Felixmil]

* Use ggtext and stringr as new dependency (both validated)

I did not know that ggtext was already validated. If so, that means we could include markdown content within plots ! :) But we would need to spread all this to the other texts/labels (e.g. axis.text, axis.title, etc.) correct ?

Yes !

This is already spread to: title, subtitle, caption and axis titles. But not for axis text (because rotations are only by increment of 90° in ggtext and user may want to apply 30/45°)

[Felixmil]

A lot of snapshots will break on ospsuiteR

Potentially also on Reporting Engine. Not sure if this will crash or not some plots or change their look. I also don't know how the translation of the fonts from showtext will perform.

My first test on OSPSuite R produced same plots but with slighly increase margins. The font seemed identical.

[Felixmil]

@pchelle This is ready for review

[pchelle]

@pchelle This is ready for review

Except for the maxWidth and charactersWidth comments, all good.

[Felixmil]

Except for the maxWidth and charactersWidth comments, all good.

Which comments ?

[pchelle]

Except for the maxWidth and charactersWidth comments, all good.

Which comments ?

• maxWidth
• charactersWidth

[Felixmil]

• maxWidth
• charactersWidth

I am sorry, I seem to not to be able to access these sections 😅

[PavelBal]

@pchelle Forgot to submit the review? :D

[pchelle]

@pchelle Forgot to submit the review? :D

Indeed ! 😅