Closed Felixmil closed 7 months ago
@Yuri05 Can we merge this now ?
Once merged, can you also create a release tag (v1) so that workflows can be used properly ? It is necessary to add a ref
tag as described here. If there is no version tag we can use commit SHA but this is not really convenient.
@Yuri05 Can we merge this now ?
Once merged, can you also create a release tag (v1) so that workflows can be used properly ? It is necessary to add a
ref
tag as described here. If there is no version tag we can use commit SHA but this is not really convenient.
@Felixmil Not all PR review comments were addressed. But we can merge now, and I will create Issues for the remaining topics - as you like :)
@Felixmil Not all PR review comments were addressed. But we can merge now, and I will create Issues for the remaining topics - as you like :)
Yes, let's work on that iteratively if that's ok
Yes, let's work on that iteratively if that's ok
Sounds good. The only thing: the refs should be added to the used composite workflow steps before merging. (So either @main or @v1 )
Sounds good. The only thing: the refs should be added to the used composite workflow steps before merging. (So either @main or @v1 )
I added @main
to reference composite actions from the reusable workflows.
Let's not bother with versions for now. We'll se in the future if we introduce breaking changes.
@Felixmil Looks good, merging. Will create issues for the remaining discussion topics later
Composite actions
Reusable workflows
These workflows make use of composite actions for steps that are needed repeated across workflows.