Open-Systems-Pharmacology / Workflows

Reusable workflows (e.g. GitHub Actions) which can be used in any OSP repository
1 stars 4 forks source link

Add r composite actions and reusable workflows #19

Closed Felixmil closed 7 months ago

Felixmil commented 7 months ago

Composite actions

Reusable workflows

These workflows make use of composite actions for steps that are needed repeated across workflows.

Felixmil commented 7 months ago

@Yuri05 Can we merge this now ?

Once merged, can you also create a release tag (v1) so that workflows can be used properly ? It is necessary to add a ref tag as described here. If there is no version tag we can use commit SHA but this is not really convenient.

Yuri05 commented 7 months ago

@Yuri05 Can we merge this now ?

Once merged, can you also create a release tag (v1) so that workflows can be used properly ? It is necessary to add a ref tag as described here. If there is no version tag we can use commit SHA but this is not really convenient.

@Felixmil Not all PR review comments were addressed. But we can merge now, and I will create Issues for the remaining topics - as you like :)

Felixmil commented 7 months ago

@Felixmil Not all PR review comments were addressed. But we can merge now, and I will create Issues for the remaining topics - as you like :)

Yes, let's work on that iteratively if that's ok

Yuri05 commented 7 months ago

Yes, let's work on that iteratively if that's ok

Sounds good. The only thing: the refs should be added to the used composite workflow steps before merging. (So either @main or @v1 )

Felixmil commented 7 months ago

Sounds good. The only thing: the refs should be added to the used composite workflow steps before merging. (So either @main or @v1 )

I added @main to reference composite actions from the reusable workflows.

Let's not bother with versions for now. We'll se in the future if we introduce breaking changes.

Yuri05 commented 7 months ago

@Felixmil Looks good, merging. Will create issues for the remaining discussion topics later