Open-Systems-Pharmacology / developer-docs

https://dev.open-systems-pharmacology.org
0 stars 2 forks source link

PK-Sim DB docu lacks an introduction section #19

Closed Yuri05 closed 1 year ago

georgeDaskalakis commented 1 year ago

@Yuri05 I have added a small intro to the DB section. Do you think it is enough, or should it actually be expanded.

Yuri05 commented 1 year ago

@georgeDaskalakis Somehow I missed this change in a PR :) Here are some change/extension suggestions:

  1. I would extend the 1st sentence to:

============================================================= PK-Sim uses an SQLite database to store:

The database can be found in the PK-Sim repository under src/Db/PKSimDB.sqlite.

=============================================================

  1. We could also add a sentence that the diagrams were created using the SchemaCrawler and point to this short wiki: https://github.com/Open-Systems-Pharmacology/developer-docs/wiki/Using-SchemaCrawler-for-creating-of-database-schema-diagrams.
georgeDaskalakis commented 1 year ago

@Yuri05 I have created a PR ( here ) adopting your suggestions.

Do you think I should move the tutorial for the SchemaCrawler from the wiki to the main documentation and add it to the index under the DB things?

Yuri05 commented 1 year ago

Do you think I should move the tutorial for the SchemaCrawler from the wiki to the main documentation and add it to the index under the DB things?

As you like - I don't have strong opinion on this :)

georgeDaskalakis commented 1 year ago

@Yuri05 OK, I am leaving it in the wiki for now. It is not exactly what you would call necessary onboarding info for a new developer contributing to OSPSuite, so I think keeping it separate does make sense